fix: correctly set the default refresh period for VMSS size (used for Spot instances)

[tallaxes]

What type of PR is this?

/kind bug
/kind regression

What this PR does / why we need it:

Correctly set the default refresh period for VMSS size (used for Spot instances)

Which issue(s) this PR fixes:

Fixes #7373

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Fix scaling of spot node pools

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

[tallaxes]

/cherry-pick cluster-autoscaler-release-1.31
/cherry-pick cluster-autoscaler-release-1.30
/cherry-pick cluster-autoscaler-release-1.29
/cherry-pick cluster-autoscaler-release-1.28
/cherry-pick cluster-autoscaler-release-1.27

[k8s-infra-cherrypick-robot]

@tallaxes: once the present PR merges, I will cherry-pick it on top of cluster-autoscaler-release-1.27, cluster-autoscaler-release-1.28, cluster-autoscaler-release-1.29, cluster-autoscaler-release-1.30, cluster-autoscaler-release-1.31 in new PRs and assign them to you.

In response to this:

/cherry-pick cluster-autoscaler-release-1.31
/cherry-pick cluster-autoscaler-release-1.30
/cherry-pick cluster-autoscaler-release-1.29
/cherry-pick cluster-autoscaler-release-1.28
/cherry-pick cluster-autoscaler-release-1.27

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[tallaxes]

/cc @comtalyst

[comtalyst]

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: comtalyst, tallaxes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• cluster-autoscaler/cloudprovider/azure/OWNERS [comtalyst,tallaxes]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-infra-cherrypick-robot]

@tallaxes: new pull request created: #7580

In response to this:

/cherry-pick cluster-autoscaler-release-1.31
/cherry-pick cluster-autoscaler-release-1.30
/cherry-pick cluster-autoscaler-release-1.29
/cherry-pick cluster-autoscaler-release-1.28
/cherry-pick cluster-autoscaler-release-1.27

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[k8s-infra-cherrypick-robot]

@tallaxes: #7579 failed to apply on top of branch "cluster-autoscaler-release-1.30":

Applying: fix: setting getVmssSizeRefreshPeriod
Applying: fix: corresponding test
Using index info to reconstruct a base tree...
M	cluster-autoscaler/cloudprovider/azure/azure_manager_test.go
Falling back to patching base and 3-way merge...
Auto-merging cluster-autoscaler/cloudprovider/azure/azure_manager_test.go
CONFLICT (content): Merge conflict in cluster-autoscaler/cloudprovider/azure/azure_manager_test.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0002 fix: corresponding test

In response to this:

/cherry-pick cluster-autoscaler-release-1.31
/cherry-pick cluster-autoscaler-release-1.30
/cherry-pick cluster-autoscaler-release-1.29
/cherry-pick cluster-autoscaler-release-1.28
/cherry-pick cluster-autoscaler-release-1.27

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[k8s-infra-cherrypick-robot]

@tallaxes: #7579 failed to apply on top of branch "cluster-autoscaler-release-1.29":

Applying: fix: setting getVmssSizeRefreshPeriod
Applying: fix: corresponding test
Using index info to reconstruct a base tree...
M	cluster-autoscaler/cloudprovider/azure/azure_manager_test.go
Falling back to patching base and 3-way merge...
Auto-merging cluster-autoscaler/cloudprovider/azure/azure_manager_test.go
CONFLICT (content): Merge conflict in cluster-autoscaler/cloudprovider/azure/azure_manager_test.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0002 fix: corresponding test

In response to this:

/cherry-pick cluster-autoscaler-release-1.31
/cherry-pick cluster-autoscaler-release-1.30
/cherry-pick cluster-autoscaler-release-1.29
/cherry-pick cluster-autoscaler-release-1.28
/cherry-pick cluster-autoscaler-release-1.27

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[k8s-infra-cherrypick-robot]

@tallaxes: #7579 failed to apply on top of branch "cluster-autoscaler-release-1.28":

Applying: fix: setting getVmssSizeRefreshPeriod
Applying: fix: corresponding test
Using index info to reconstruct a base tree...
M	cluster-autoscaler/cloudprovider/azure/azure_manager_test.go
Falling back to patching base and 3-way merge...
Auto-merging cluster-autoscaler/cloudprovider/azure/azure_manager_test.go
CONFLICT (content): Merge conflict in cluster-autoscaler/cloudprovider/azure/azure_manager_test.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0002 fix: corresponding test

In response to this:

/cherry-pick cluster-autoscaler-release-1.31
/cherry-pick cluster-autoscaler-release-1.30
/cherry-pick cluster-autoscaler-release-1.29
/cherry-pick cluster-autoscaler-release-1.28
/cherry-pick cluster-autoscaler-release-1.27

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[k8s-infra-cherrypick-robot]

@tallaxes: #7579 failed to apply on top of branch "cluster-autoscaler-release-1.27":

Applying: fix: setting getVmssSizeRefreshPeriod
Applying: fix: corresponding test
Using index info to reconstruct a base tree...
M	cluster-autoscaler/cloudprovider/azure/azure_manager_test.go
Falling back to patching base and 3-way merge...
Auto-merging cluster-autoscaler/cloudprovider/azure/azure_manager_test.go
CONFLICT (content): Merge conflict in cluster-autoscaler/cloudprovider/azure/azure_manager_test.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0002 fix: corresponding test

In response to this:

/cherry-pick cluster-autoscaler-release-1.31
/cherry-pick cluster-autoscaler-release-1.30
/cherry-pick cluster-autoscaler-release-1.29
/cherry-pick cluster-autoscaler-release-1.28
/cherry-pick cluster-autoscaler-release-1.27

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[comtalyst]

New cherry-pick PRs for 1.27-1.30:
#7581, #7582, #7583, #7584

Automated cherry-picks have failed due to cross-version code difference from a new feature in 1.31 (#6863).