-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(fix): Fix from the pre-commit integration #7468
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: pierluigilenoci The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @pierluigilenoci. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Signed-off-by: Pierluigi Lenoci <[email protected]>
8cf1b1b
to
59c3756
Compare
I think it makes sense to add pre-commit to a GitHub Action, if you're going through the effort of making it pass |
I'm also unsure if there's value in fixing (and testing) the vendored files |
@adrianmoisey, I understand your observations, but the purpose of this PR is not to integrate pre-commit tests into the pipeline. In that case, we would also have to rethink the pre-commit tests if they are going to check files that do not make sense for them to be. However, this PR only removes whitespace and new lines where they shouldn't be according to pre-commit tests. |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What type of PR is this?
/kind cleanup
/kind failing-test
/kind regression
What this PR does / why we need it:
In the master branch, the pre-commit test fails miserably, with these fixes it's ok.
Which issue(s) this PR fixes:
Fixes #7469
Special notes for your reviewer:
Nope
Does this PR introduce a user-facing change?
NONE
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: