-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: backport latest VMs pool and HasInstance() implementations, for 1.30 #7201
chore: backport latest VMs pool and HasInstance() implementations, for 1.30 #7201
Conversation
/label tide/merge-method-squash |
@comtalyst: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
/assign @towca |
/lgtm |
Could you remove the vendor changes from the PR? We've removed the vendor dir from CA altogether, see #4878. |
ab058dc
to
28bb28c
Compare
Ahh my bad, indeed vendor is still there on 1.30. Sorry for the confusion. /approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: comtalyst, tallaxes, towca The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
7a46404
into
kubernetes:cluster-autoscaler-release-1.30
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
These differences have effectively disabled cherry-pick automation in these areas. Upcoming changes (e.g., more VMs pool implementation, cloud-provider-azure integration rework, more fixes that need to be done in all versions) will be agonizing experiences, not to mention the past ones.
This PR will amend some of those differences, which is mostly VMs pool and HasInstance() implementations. They cannot be cherry-picked in normal means easily due to conflict with Azure defork operations, which have to resolve these conflicts at some point anyway.
Which issue(s) this PR fixes:
Special notes for your reviewer:
Original
HasInstance()
implementation PR: #6956Differences visualization I used as a reference, with some labels: https://github.com/comtalyst/autoscaler/pull/3/files
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: