-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1.28 Adding temporary multizone-nodepool support for CAS #7194
1.28 Adding temporary multizone-nodepool support for CAS #7194
Conversation
Hi @aagusuab. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
a2bd63c
to
b10e36c
Compare
/ok-to-test |
@@ -24,14 +24,13 @@ import ( | |||
"strings" | |||
"time" | |||
|
|||
"github.com/Azure/azure-sdk-for-go/services/compute/mgmt/2022-08-01/compute" //nolint SA1019 - deprecated package | |||
"github.com/Azure/azure-sdk-for-go/services/compute/mgmt/2022-08-01/compute" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why? (1.27 still keep it)
@@ -20,10 +20,11 @@ import ( | |||
"fmt" | |||
"testing" | |||
|
|||
//nolint SA1019 - deprecated package | |||
|
|||
"github.com/Azure/azure-sdk-for-go/services/compute/mgmt/2022-08-01/compute" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: this line is missing //nolint SA1019 - deprecated package
if we compare with the fork
@aagusuab: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aagusuab, comtalyst The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
e1501b0
into
kubernetes:cluster-autoscaler-release-1.28
What type of PR is this?
/kind feature
What this PR does / why we need it:
This is a cherry-pick for #7013
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: