Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regenerate azure static sku list for 1.30 #7112

Conversation

rakechill
Copy link
Contributor

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Regenerates the static sku list that acts as a fallback mechanism for dynamic listing

Special notes for your reviewer:

I compared against the output for az vm --list-skus -o json. The memory updates + deprecated types are accurate.

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@k8s-ci-robot k8s-ci-robot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Aug 1, 2024
Copy link

linux-foundation-easycla bot commented Aug 1, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: rakechill / name: Rachel Gregory (7e4b145)

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 1, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @rakechill. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. area/cluster-autoscaler labels Aug 1, 2024
@k8s-ci-robot k8s-ci-robot added area/provider/aws Issues or PRs related to aws provider area/provider/azure Issues or PRs related to azure provider area/provider/hetzner Issues or PRs related to Hetzner provider size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Aug 1, 2024
@rakechill rakechill changed the base branch from master to cluster-autoscaler-release-1.30 August 1, 2024 19:37
@rakechill
Copy link
Contributor Author

accidentally had master as the base branch at first. updated to 1.30 release branch

@rakechill
Copy link
Contributor Author

CLA Not Signed

bummer... since I accidentally had master as my base branch when I created the PR, easyCLA ran on all of the commits that were different between my branch (based off of 1.30) and master. One of these was a cherry-commit which I don't have permissions to run...

@tallaxes
Copy link
Contributor

tallaxes commented Aug 1, 2024

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 1, 2024
@tallaxes
Copy link
Contributor

tallaxes commented Aug 1, 2024

/remove-area cluster-autoscaler
/remove-area provider/aws
/remove-area provider/hetzner

@k8s-ci-robot k8s-ci-robot removed area/cluster-autoscaler area/provider/aws Issues or PRs related to aws provider area/provider/hetzner Issues or PRs related to Hetzner provider labels Aug 1, 2024
@tallaxes
Copy link
Contributor

tallaxes commented Aug 1, 2024

/easycla

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Aug 1, 2024
@tallaxes
Copy link
Contributor

tallaxes commented Aug 1, 2024

bummer... since I accidentally had master as my base branch when I created the PR, easyCLA ran on all of the commits that were different between my branch (based off of 1.30) and master. One of these was a cherry-commit which I don't have permissions to run...

Fixed

@tallaxes
Copy link
Contributor

tallaxes commented Aug 1, 2024

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 1, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rakechill, tallaxes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 1, 2024
@k8s-ci-robot k8s-ci-robot merged commit 564ba7c into kubernetes:cluster-autoscaler-release-1.30 Aug 1, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/azure Issues or PRs related to azure provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants