Only render ServiceMonitor annotations if not empty

[Kellen275]

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

This PR applies the same logic used in other templates/ to the annotations of the ServiceMonitor.

While this is good general cleanup, this also has a side-effect of improving ArgoCD integration. Without this, if you leave the annotations default (empty) and deploy with ArgoCD, it will always detect a noop diff

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

[k8s-ci-robot]

Welcome @Kellen275!

It looks like this is your first PR to kubernetes/autoscaler 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/autoscaler has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @Kellen275. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[Shubham82]

/ok-to-test

[Shubham82]

/lgtm

[Kellen275]

Hi @Shubham82 , is there anything remaining for this PR?

[Shubham82]

@Kellen275, To merge this PR, needs approval (/approve label) from the approver.

[Shubham82]

cc @gjtempleton
PTAL!

[Shubham82]

@Kellen275, please resolve the merge conflict.

[jackfrancis]

/lgtm

/hold

we'll get this in the queue, sorry in advance for needing to rebase + rev the chart version once again

[jackfrancis]

This is ready for merge! Could you kindly:

1. rebase
2. set new chart version to 9.43.0
3. squash commits

thank you!

[jackfrancis]

/lgtm

cc @gjtempleton for approval

[gjtempleton]

Thanks!
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gjtempleton, Kellen275

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• charts/OWNERS [gjtempleton]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[jackfrancis]

/hold cancel