Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated k8s.io/legacy-cloud-providers #6953

Merged
merged 1 commit into from
Jun 21, 2024

Conversation

azylinski
Copy link
Contributor

Replace single reference with cloud-provider-gcp

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

This is part of an larger effort in k/k: https://kubernetes.io/blog/2023/12/14/cloud-provider-integration-changes/

Special notes for your reviewer:

New config it's an extension of an old one - it has an extra option: "stack-type" and all the previous ones are included already. In other words, in ensures compatibility.

Diff:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

- [KEP-2395]: [Removing In-Tree Cloud Provider Code](https://github.com/kubernetes/enhancements/tree/master/keps/sig-cloud-provider/2395-removing-in-tree-cloud-providers)

Replace single reference with cloud-provider-gcp
@k8s-ci-robot k8s-ci-robot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Jun 21, 2024
@k8s-ci-robot k8s-ci-robot requested a review from towca June 21, 2024 10:43
@k8s-ci-robot k8s-ci-robot requested a review from x13n June 21, 2024 10:43
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/provider/gce size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jun 21, 2024
@BigDarkClown
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 21, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: azylinski, BigDarkClown

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 21, 2024
@k8s-ci-robot k8s-ci-robot merged commit a7366a2 into kubernetes:master Jun 21, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cluster-autoscaler area/provider/gce cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants