Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ProvisioningRequest update #6777

Merged
merged 2 commits into from
May 13, 2024
Merged

Fix ProvisioningRequest update #6777

merged 2 commits into from
May 13, 2024

Conversation

yaroslava-serdiuk
Copy link
Contributor

What type of PR is this?

/kind bug

Implementation of ProvisioningRequest missed the real update of the object.

@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Apr 29, 2024
@k8s-ci-robot k8s-ci-robot requested a review from x13n April 29, 2024 11:12
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 29, 2024
MaciekPytel
MaciekPytel reviewed Apr 29, 2024
View reviewed changes
cluster-autoscaler/processors/provreq/provisioning_request_processor.go Outdated
@@ -26,7 +26,7 @@ import (

// ProvisioningRequestProcessor process ProvisioningRequests in the cluster.
type ProvisioningRequestProcessor interface {
Process([]*provreqwrapper.ProvisioningRequest)
Process(*provreqclient.ProvisioningRequestClient, []*provreqwrapper.ProvisioningRequest)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not clearly related to this PR, but I think all processors are generally expected to take AutoscalingContext as first parameter.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ProvisioningRequestProcessor doesn't depend on AutoscalingContext

@yaroslava-serdiuk
Copy link
Contributor Author

cc: @aleksandra-malinowska

kisieland
kisieland reviewed May 7, 2024
View reviewed changes
Copy link
Contributor

@kisieland kisieland left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment

cluster-autoscaler/provisioningrequest/checkcapacity/provisioningclass.go Outdated Show resolved Hide resolved
@yaroslava-serdiuk yaroslava-serdiuk force-pushed the check-capacity branch 2 times, most recently from b4a878e to 9a3da04 Compare May 7, 2024 13:18
@x13n
Copy link
Member

x13n commented May 7, 2024

/assign @kisieland @aleksandra-malinowska @MaciekPytel

Looks like all of you are reviewing this already.

@k8s-ci-robot
Copy link
Contributor

@x13n: GitHub didn't allow me to assign the following users: kisieland.

Note that only kubernetes members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @kisieland @aleksandra-malinowska @MaciekPytel

Looks like all of you are reviewing this already.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kisieland
Copy link
Contributor

/lgtm

@k8s-ci-robot
Copy link
Contributor

@kisieland: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@x13n
Copy link
Member

x13n commented May 8, 2024

@kisieland maybe it's time for you to join k8s org :)

@aleksandra-malinowska
Copy link
Contributor

/lgtm

@x13n while this PR may have a lot of reviews, it's missing approvers

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 10, 2024
@yaroslava-serdiuk
Copy link
Contributor Author

#6814

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 13, 2024
@towca
Copy link
Collaborator

towca commented May 13, 2024

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 13, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: towca, yaroslava-serdiuk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 13, 2024
@k8s-ci-robot k8s-ci-robot merged commit 76d914b into kubernetes:master May 13, 2024
6 checks passed
@k8s-infra-cherrypick-robot
Copy link

@yaroslava-serdiuk: new pull request could not be created: failed to create pull request against kubernetes/autoscaler#cluster-autoscaler-1.30.0 from head k8s-infra-cherrypick-robot:cherry-pick-6777-to-cluster-autoscaler-1.30.0: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","field":"base","code":"invalid"}],"documentation_url":"https://docs.github.com/rest/pulls/pulls#create-a-pull-request"}

In response to this:

/cherry-pick cluster-autoscaler-1.30.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-infra-cherrypick-robot
Copy link

@yaroslava-serdiuk: cannot checkout cluster-autoscaler-release-1.30.0: error checking out "cluster-autoscaler-release-1.30.0": exit status 1 error: pathspec 'cluster-autoscaler-release-1.30.0' did not match any file(s) known to git

In response to this:

/cherry-pick cluster-autoscaler-release-1.30.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@yaroslava-serdiuk
Copy link
Contributor Author

/cherry-pick cluster-autoscaler-release-1.30

@k8s-infra-cherrypick-robot
Copy link

@yaroslava-serdiuk: new pull request created: #6825

In response to this:

/cherry-pick cluster-autoscaler-release-1.30

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request May 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@towca towca towca left review comments

@kisieland kisieland kisieland left review comments

@MaciekPytel MaciekPytel MaciekPytel left review comments

@aleksandra-malinowska aleksandra-malinowska aleksandra-malinowska left review comments

@BigDarkClown BigDarkClown Awaiting requested review from BigDarkClown

@x13n x13n Awaiting requested review from x13n

Assignees

@aleksandra-malinowska aleksandra-malinowska

@MaciekPytel MaciekPytel

@towca towca

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cluster-autoscaler cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@yaroslava-serdiuk @x13n @k8s-ci-robot @kisieland @aleksandra-malinowska @towca @k8s-infra-cherrypick-robot @MaciekPytel