Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport #6617 ionoscloud: Update ionos-cloud sdk-go and add metrics into CA 1.29 #6629

Merged
merged 1 commit into from
Mar 14, 2024
Merged

Backport #6617 ionoscloud: Update ionos-cloud sdk-go and add metrics into CA 1.29 #6629

merged 1 commit into from
Mar 14, 2024

Conversation

avorima
Copy link
Contributor

@avorima avorima commented Mar 13, 2024 •
edited
Loading

What type of PR is this?

/kind cleanup
/kind feature

What this PR does / why we need it:

This PR is cherry-picked, which backports #6617 into CA 1.29.

Does this PR introduce a user-facing change?

Add `cluster_autoscaler_ionoscloud_api_request_total` alpha metric

@k8s-ci-robot @avorima
Merge pull request kubernetes#6617 from ionos-cloud/update-ionos-sdk
da42fcc 
ionoscloud: Update ionos-cloud sdk-go and add metrics
@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Mar 13, 2024
@k8s-ci-robot k8s-ci-robot requested review from kgolab and x13n March 13, 2024 16:50
@avorima
Copy link
Contributor Author

avorima commented Mar 13, 2024

/area cluster-autoscaler

@avorima avorima marked this pull request as ready for review March 13, 2024 17:31
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 13, 2024
@k8s-ci-robot k8s-ci-robot requested a review from feiskyer March 13, 2024 17:32
@avorima avorima mentioned this pull request Mar 13, 2024
Closed
@Shubham82
Copy link
Contributor

Thanks @avorima
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 14, 2024
mwielgus
mwielgus approved these changes Mar 14, 2024
View reviewed changes
Copy link
Contributor

@mwielgus mwielgus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: avorima, mwielgus, piepmatz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 14, 2024
@k8s-ci-robot k8s-ci-robot merged commit 642c18b into kubernetes:cluster-autoscaler-release-1.29 Mar 14, 2024
6 checks passed
@avorima avorima deleted the update-ionos-sdk-1.29 branch March 19, 2024 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mwielgus mwielgus mwielgus approved these changes

@piepmatz piepmatz piepmatz approved these changes

@kgolab kgolab Awaiting requested review from kgolab

@x13n x13n Awaiting requested review from x13n

@feiskyer feiskyer Awaiting requested review from feiskyer

Assignees

@mwielgus mwielgus

@Shubham82 Shubham82

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cluster-autoscaler area/provider/ionoscloud cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@avorima @Shubham82 @k8s-ci-robot @piepmatz @mwielgus