Introduce LocalSSDSizeProvider interface for GCE #6530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
kind/feature
k8s-ci-robot
added
area/provider/externalgrpc
k8s-ci-robot
added
the
do-not-merge/work-in-progress
atwamahmoud
force-pushed
the
local-ssd-size-provider
branch
3 times, most recently
from
3ada471 to
4dd3885
Compare
atwamahmoud
force-pushed
the
local-ssd-size-provider
branch
from
4dd3885 to
e7ff1cd
Compare
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
|
This PR may require API review. If so, when the changes are ready, complete the pre-review checklist and request an API review. Status of requested reviews is tracked in the API Review project. |
|
@atwamahmoud: Those labels are not set on the issue: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/remove-kind api-change |
k8s-ci-robot
added
area/vertical-pod-autoscaler
needs-rebase
atwamahmoud
force-pushed
the
local-ssd-size-provider
branch
from
a00db07 to
e7ff1cd
Compare
k8s-ci-robot
added
size/L
k8s-ci-robot
removed
the
needs-rebase
cluster-autoscaler/cloudprovider/gce/localssdsize/local_ssd_size_provider.go
Outdated
Show resolved
Hide resolved
k8s-ci-robot
added
lgtm
atwamahmoud
force-pushed
the
local-ssd-size-provider
branch
from
87a38e2 to
f9e6a8d
Compare
k8s-ci-robot
removed
the
lgtm
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: atwamahmoud, BigDarkClown The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
Introduces
LocalSSDSizeProviderinterface to GCE cloud provider to be used to calculate local ssd disk size instead of using a plain constant.Also introduces
SimpleLocalSSDProviderstruct implementingLocalSSDSizeProviderwhich returns a constant value375GiBto maintain original behaviourSpecial notes for your reviewer:
Does this PR introduce a user-facing change?