Fix e2e test setup #6511
Merged
Fix e2e test setup #6511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
kind/bug
k8s-ci-robot
added
the
size/XXL
voelzmo
force-pushed
the
fix/vpa-e2e-test-setup
branch
2 times, most recently
from
ba3efdf to
1209c57
Compare
k8s-ci-robot
added
size/M
|
@laoj2 @sophieliu15 can you take a look and get this merged, please? Fixing e2e tests is a bit cumbersome, as they run forever, sorry ;( |
voelzmo
force-pushed
the
fix/vpa-e2e-test-setup
branch
from
1209c57 to
fd7fde9
Compare
voelzmo
force-pushed
the
fix/vpa-e2e-test-setup
branch
from
fd7fde9 to
2de6976
Compare
|
Not being able to run e2e tests is bad and blocks the ability to create a release. Tagging current OWNERS to please have a look |
|
/lgtm @kwiesmueller Could you take a look? |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kwiesmueller, voelzmo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
/kind failing-test
What this PR does / why we need it:
Fixing the e2e test setup issues created by the helper refactorings in #5599
PR #6391 helped but some other issues were masked beyond these errors.
Which issue(s) this PR fixes:
Fixes #6510
Special notes for your reviewer:
Does this PR introduce a user-facing change?