-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(cluster-autoscaler-chart): if secretKeyRefNameOverride is true, d… #6206
Conversation
…on't create secret Signed-off-by: Jonathan Raymond <[email protected]>
Welcome @jonwraymond! |
Signed-off-by: Jonathan Raymond <[email protected]>
@jonwraymond, Please sign the CLA before the PR can be reviewed. |
To check EasyCLA /easycla |
/easycla |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jonwraymond, mwielgus The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…on't create secret
Don't create secret if
secretKeyRefNameOverride
is used/kind bug
What this PR does / why we need it:
Don't create secret if
secretKeyRefNameOverride
is used in the helm chart for cluster autoscaler.Fixes #
Special notes for your reviewer:
Clean up so no extra secret is created unnecessarily.
Does this PR introduce a user-facing change?