Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix broken hyperlink #5987

Merged
merged 1 commit into from
Aug 4, 2023
Merged

Fix broken hyperlink #5987

merged 1 commit into from
Aug 4, 2023

Conversation

droctothorpe
Copy link
Contributor

@droctothorpe droctothorpe commented Jul 26, 2023 •
edited
Loading

What type of PR is this?

/kind documentation

What this PR does / why we need it:

This tiny PR just fixes a broken hyperlink in the FAQ.

Does this PR introduce a user-facing change?

None

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 26, 2023
@k8s-ci-robot
Copy link
Contributor

Welcome @droctothorpe!

It looks like this is your first PR to kubernetes/autoscaler 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/autoscaler has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 26, 2023
Shubham82
Shubham82 suggested changes Jul 27, 2023
View reviewed changes
cluster-autoscaler/FAQ.md Outdated Show resolved Hide resolved
@droctothorpe droctothorpe changed the title Fix typo and broken hyperlink Fix broken hyperlink Jul 28, 2023
@droctothorpe @Shubham82
Fix broken hyperlink
ecfdc21 
Co-authored-by: Shubham <[email protected]>
@droctothorpe
Copy link
Contributor Author

droctothorpe commented Jul 28, 2023 •
edited
Loading

Thanks for the input. Merged suggestions. Squashed. Kept you as co-author, @Shubham82. Updated commit message, PR title, and PR description accordingly.

What's the joke?
10 line PR: 10 comments.
10,000 line PR: 0 comments.

🙃

@Shubham82
Copy link
Contributor

Thanks, @droctothorpe
it looks good to me.
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 28, 2023
@droctothorpe
Copy link
Contributor Author

What's the next step, @Shubham82?

@Shubham82
Copy link
Contributor

@droctothorpe you can ask feiskyer for approval by assiging the issue to him.
See this comment

mwielgus
mwielgus approved these changes Aug 4, 2023
View reviewed changes
Copy link
Contributor

@mwielgus mwielgus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: droctothorpe, mwielgus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 4, 2023
@k8s-ci-robot k8s-ci-robot merged commit bee7c0f into kubernetes:master Aug 4, 2023
@droctothorpe
Copy link
Contributor Author

Thank you, frondz! Does this mean I get to go to the contributor lounge at kubecon? 😂 Hopefully more substantive contributions to follow.

@droctothorpe droctothorpe deleted the typos branch August 4, 2023 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mwielgus mwielgus mwielgus approved these changes

@BigDarkClown BigDarkClown Awaiting requested review from BigDarkClown

@feiskyer feiskyer Awaiting requested review from feiskyer

@Shubham82 Shubham82 Awaiting requested review from Shubham82

@lzhecheng lzhecheng Awaiting requested review from lzhecheng

Assignees

@mwielgus mwielgus

@Shubham82 Shubham82

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cluster-autoscaler cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@droctothorpe @k8s-ci-robot @Shubham82 @mwielgus @lzhecheng