-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): update vendored hcloud-go to 2.0.0 #5961
Conversation
Generated by: ``` UPSTREAM_REF=v2.0.0 hack/update-vendor.sh ```
/lgtm |
@LKaemmerling: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Can I lgtm my own PR? Lukas is in the Owners file but not part of the Kubernetes org: https://github.com/kubernetes/autoscaler/blob/master/cluster-autoscaler/cloudprovider/hetzner/OWNERS /lgtm |
@apricote: you cannot LGTM your own PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@feiskyer @BigDarkClown Could one of you /lgtm this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: apricote, jooola, LKaemmerling, mwielgus The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Update the vendored copy of
github.com/hetznercloud/hcloud-go
to 2.0.0. This includes a breaking change where we changed the type of allid
fields fromint
toint64
. Read more about this in our docs.As updating the vendored code is annoying, I wrote a script that automatically updates the vendor. This has removed the License headers (Apache) which were added when the code was originally vendored. Instead I kept around the "LICENSE" (MIT) file from the hcloud-go repo.
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: