Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update vendored hcloud-go to 2.0.0 #5961

Merged
merged 2 commits into from
Aug 4, 2023

Conversation

apricote
Copy link
Member

What type of PR is this?

/kind feature

What this PR does / why we need it:

Update the vendored copy of github.com/hetznercloud/hcloud-go to 2.0.0. This includes a breaking change where we changed the type of all id fields from int to int64. Read more about this in our docs.

As updating the vendored code is annoying, I wrote a script that automatically updates the vendor. This has removed the License headers (Apache) which were added when the code was originally vendored. Instead I kept around the "LICENSE" (MIT) file from the hcloud-go repo.

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jul 17, 2023
@k8s-ci-robot k8s-ci-robot added area/provider/hetzner Issues or PRs related to Hetzner provider approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cluster-autoscaler labels Jul 17, 2023
@LKaemmerling
Copy link
Contributor

/lgtm

@k8s-ci-robot
Copy link
Contributor

@LKaemmerling: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@apricote
Copy link
Member Author

Can I lgtm my own PR?

Lukas is in the Owners file but not part of the Kubernetes org: https://github.com/kubernetes/autoscaler/blob/master/cluster-autoscaler/cloudprovider/hetzner/OWNERS

/lgtm

@k8s-ci-robot
Copy link
Contributor

@apricote: you cannot LGTM your own PR.

In response to this:

Can I lgtm my own PR?

Lukas is in the Owners file but not part of the Kubernetes org: https://github.com/kubernetes/autoscaler/blob/master/cluster-autoscaler/cloudprovider/hetzner/OWNERS

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@apricote
Copy link
Member Author

apricote commented Aug 2, 2023

@feiskyer @BigDarkClown Could one of you /lgtm this PR?

Copy link
Contributor

@mwielgus mwielgus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 4, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: apricote, jooola, LKaemmerling, mwielgus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit c9b8eee into kubernetes:master Aug 4, 2023
@jooola jooola deleted the hcloud-go-v2 branch August 4, 2023 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cluster-autoscaler area/provider/hetzner Issues or PRs related to Hetzner provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants