Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

protect admission against empty keys #5900

Closed
Changes from 1 commit
Commits
Show all changes
175 commits
Select commit Hold shift + click to select a range
0ee3abf
Check power state before flagging instance as provisioning failed
domenicbozzuto May 6, 2023
fab8ec7
feat(*): add more metrics
qianlei90 Jan 12, 2023
7217870
fix: don't clean `CriticalAddonsOnly` taint from template nodes
vadasambar Jun 6, 2023
adde651
fix: CA on fargate causing log flood
vadasambar Jun 23, 2023
ec01059
test: fix node names
vadasambar Jun 23, 2023
1847875
Move two util functions from actuator to delete_in_batch, where they …
kawych May 31, 2023
61b7958
Add support for atomic scale-down in node group options
kawych May 31, 2023
292a517
Extract cropNodesToBudgets function out of actuator file
kawych May 31, 2023
7e3e15b
Support atomic scale-down option for node groups
kawych May 31, 2023
1ecb843
Respond to readability-related comments from the review
kawych Jun 21, 2023
257e66c
Don't pass NodeGroup as a parameter to functions running asynchronously
kawych Jun 21, 2023
5448bd2
Add unit test for group_deletion_scheduler
kawych Jun 21, 2023
05e1fe1
Use single AtomicScaling option for scale up and scale down
kawych Jun 26, 2023
374cf61
Address next set of comments
kawych Jun 27, 2023
76a7d21
update agnhost image to pull from registry.k8s.io
kwiesmueller Jun 27, 2023
08c8ba0
protect admission against empty keys
dbenque Jun 28, 2023
753b024
Bugfix for budget cropping
kawych Jun 28, 2023
72c0a7e
Remove unneeded node groups regardless of scale down being in cooldown.
olagacek Jun 28, 2023
03b45e2
Merge pull request #5895 from kwiesmueller/e2e-todo-1
k8s-ci-robot Jun 28, 2023
0e7d327
Update VPA vendor
jbartosik Jun 28, 2023
db507cd
Replace `BuildTestContainer` with use of builder
kwiesmueller Jun 27, 2023
5a23f69
Merge pull request #5904 from jbartosik/update-vpa-vendor
k8s-ci-robot Jun 28, 2023
8f83f7e
Merge pull request #5896 from kwiesmueller/test-util-builder-cleanup
k8s-ci-robot Jun 28, 2023
d3a1f4f
Quote temp folder name parameter to avoid errors
voelzmo Jun 29, 2023
67d3e7e
Include short unregistered nodes in calculation of incorrect node group
BigDarkClown Jun 27, 2023
973f9fd
Merge pull request #5894 from BigDarkClown/fix-cs
k8s-ci-robot Jun 29, 2023
4c55b17
Merge pull request #5695 from kawych/tpu
k8s-ci-robot Jun 30, 2023
6c7ae1a
Add BigDarkClown to Cluster Autoscaler approvers
BigDarkClown Jun 29, 2023
0dd63f1
Merge pull request #5915 from BigDarkClown/be-approver
k8s-ci-robot Jun 30, 2023
c887626
Merge pull request #5913 from voelzmo/fix/generate-crds-with-weird-te…
k8s-ci-robot Jun 30, 2023
7b8e0e6
Add support for scaling up ZeroToMaxNodesScaling node groups
hbostan May 31, 2023
c255aaa
Use appropriate logging levels
hbostan May 31, 2023
38d18c6
Remove unused field in expander and add comment about estimator
hbostan Jun 1, 2023
79c611c
Merge tests for ZeroToMaxNodesScaling into one table-driven test.
hbostan Jun 26, 2023
8ba34ea
Change handling of scale up options for ZeroToMaxNodeScaling in orche…
hbostan Jun 26, 2023
333a028
Rename the autoscaling option
hbostan Jun 29, 2023
e6397c6
Merge pull request #5826 from hbostan/master
k8s-ci-robot Jun 30, 2023
d6e016f
Record all vpa api versions in recommender metrics
kwiesmueller Jun 15, 2023
1f342ff
Add subresource status for vpa
wu0407 Jun 29, 2023
3eacc05
Merge pull request #5813 from qianlei90/feat-add-metrics
k8s-ci-robot Jul 3, 2023
136976e
Merge pull request #5864 from kwiesmueller/master
k8s-ci-robot Jul 3, 2023
3c32e77
Merge pull request #5911 from wu0407/add-status-subresource
k8s-ci-robot Jul 3, 2023
a947ec1
Implement threshold interface for use by threshold based limiter
ystryuchkov Jun 30, 2023
7c293ae
Merge branch 'master' into feature/runtime-limits
ystryuchkov Jul 3, 2023
0d0e3fc
Fix tests
ystryuchkov Jul 3, 2023
adb16c8
Merge pull request #5901 from olagacek/master
k8s-ci-robot Jul 4, 2023
363fd16
Merge branch 'kubernetes:master' into feature/runtime-limits
ystryuchkov Jul 4, 2023
5fed449
Add ClusterStateRegistry to the AutoscalingContext.
kisieland Jun 28, 2023
f3dfeee
Make signature of GetDurationLimit uniformed with GetNodeLimit
ystryuchkov Jul 4, 2023
b4213d8
Add support for negative binpacking duration limit in threshold based…
ystryuchkov Jul 5, 2023
2779677
Merge pull request #5917 from ystryuchkov/feature/runtime-limits
k8s-ci-robot Jul 5, 2023
4606cdf
Merge pull request #5905 from kisieland/auto-context
k8s-ci-robot Jul 5, 2023
481a733
update RBAC to only use verbs that exist for the resources
MaxRink Jul 5, 2023
dbff9be
Move powerState to azure_util, change default to powerStateUnknown
domenicbozzuto Jul 5, 2023
b569db4
Merge pull request #5767 from DataDog/bugfix-azure-prevent-unneeded-s…
k8s-ci-robot Jul 5, 2023
8de66e1
test: fix failing tests
vadasambar Jul 6, 2023
7941bab
feat: set `IgnoreDaemonSetsUtilization` per nodegroup
vadasambar Apr 10, 2023
7eb0910
test: fix merge conflicts in actuator tests
vadasambar Jul 5, 2023
eff7888
refactor: use `actuatorNodeGroupConfigGetter` param in `NewActuator`
vadasambar Jul 5, 2023
e1a22da
test: refactor eligibility tests
vadasambar Jul 5, 2023
8a73d8e
refactor: remove comment line (not relevant anymore)
vadasambar Jul 6, 2023
1e45078
fix: dynamic assignment of the scale down threshold flags. Setting ma…
Jun 26, 2023
0f8502c
Refactor autoscaler.go and static_autoscalar.go to move declaration o…
damikag Jul 6, 2023
1ce7553
Merge pull request #5887 from vadasambar/fix/5842/fargate-nodes-causi…
k8s-ci-robot Jul 10, 2023
d7fb388
Merge pull request #5933 from damikag/fix-bsp
k8s-ci-robot Jul 11, 2023
4e3e7c6
Fixed go:build tags for ovhcloud
Shubham82 Jul 12, 2023
18a7330
Update the go:build tag for missing cloud providers.
Shubham82 Jul 12, 2023
7c716dd
Adapt FAQ for Pods without controller
voelzmo Jul 12, 2023
c6893e9
Merge pull request #5672 from vadasambar/feat/5399/ignore-daemonsets-…
k8s-ci-robot Jul 12, 2023
3cad43a
Use strings instead of NodeGroups as map keys in budgets.go
kawych Jul 12, 2023
a23a8da
Delete dead code from budgets.go
kawych Jul 12, 2023
24194b2
Re-introduce asynchronous node deletion and clean node deletion logic.
kawych Jul 11, 2023
da96d89
Merge pull request #5890 from Bryce-Soghigian/bsoghigian/respecting-b…
k8s-ci-robot Jul 12, 2023
23f03e1
feat: support custom scheduler config for in-tree schedulr plugins (w…
vadasambar Apr 25, 2023
ec783d2
Merge pull request #5945 from kawych/tpu
k8s-ci-robot Jul 13, 2023
eb2accb
Use fixed version of golang image
krzysied Jul 14, 2023
dd951b0
Fix TestBinpackingLimiter flake
BigDarkClown Jul 14, 2023
38c2e89
Merge pull request #5954 from krzysied/master_golang_fix
k8s-ci-robot Jul 14, 2023
75c698c
Bump golang from 1.20.5 to 1.20.6 in /vertical-pod-autoscaler/builder
dependabot[bot] Jul 14, 2023
4d7ba81
Merge pull request #5956 from BigDarkClown/fix-conc
k8s-ci-robot Jul 14, 2023
e5bc070
Fix: Do not inject fakeNode for instance which has errors on create
azylinski Jul 10, 2023
f7acf94
Merge pull request #5939 from azylinski/fix-do-not-inject-fakeNode-fo…
k8s-ci-robot Jul 17, 2023
8d39bae
chore: add script to update vendored hcloud-go
apricote Jul 17, 2023
ab0096f
chore(deps): update vendored hcloud-go to 2.0.0
apricote Jul 17, 2023
686900b
Merge pull request #5838 from vadasambar/fix/4097/critical-addons-tai…
k8s-ci-robot Jul 17, 2023
9fc1b81
fix: balancer RBAC permission to update balancer status
a7i Jul 18, 2023
9acd722
CA - AWS Cloudprovider OWNERS Update
gjtempleton Jul 18, 2023
e87f793
Merge pull request #5944 from voelzmo/enh/doc-for-pods-without-contro…
k8s-ci-robot Jul 19, 2023
171021c
Merge pull request #5708 from vadasambar/feat/5106/support-custom-sch…
k8s-ci-robot Jul 20, 2023
a19caa2
Merge pull request #5971 from gjtempleton/CA-AWS-Maintainers-Update
k8s-ci-robot Jul 21, 2023
990cd65
Enable parallel drain by default.
x13n Jul 21, 2023
157c68f
Merge pull request #5976 from x13n/parallel-drain
k8s-ci-robot Jul 21, 2023
fb1a4c2
Merge pull request #5948 from kubernetes/dependabot/docker/vertical-p…
k8s-ci-robot Jul 24, 2023
e1644f9
Add BigDarkClown to patch releases schedule
BigDarkClown Jul 24, 2023
d077937
Merge pull request #5978 from BigDarkClown/change-release-schedule
k8s-ci-robot Jul 24, 2023
9c364f9
Update Cluster Autoscaler vendor to K8s 1.28.0-beta.0
BigDarkClown Jul 24, 2023
21229d3
Add EstimationAnalyserFunc to be run at the end of the estimation logic
azylinski Jul 20, 2023
954d1a0
Merge pull request #5943 from Shubham82/fix-build
k8s-ci-robot Jul 25, 2023
5c22eb7
Merge pull request #5941 from Shubham82/fix_ovhcloud_build_file
k8s-ci-robot Jul 25, 2023
8c749fc
Merge pull request #5980 from BigDarkClown/vendor
k8s-ci-robot Jul 25, 2023
734c268
Remove ChangeRequirements with `OrEqual`
voelzmo Jul 25, 2023
2a0dea3
Add EvictionRequirements to types
voelzmo Sep 7, 2022
1b35940
Run `generate-crd-yaml.sh`
voelzmo Mar 15, 2023
2eba540
Add metrics for improved observability:
kawych Jul 14, 2023
63eab4e
Merge pull request #5974 from azylinski/add-estimator-PostPackingFunc
k8s-ci-robot Jul 26, 2023
ac092a9
Add requirement for Custom Resources to VPA FAQ
voelzmo Jul 24, 2023
b0ddb47
Clarify Eviction Control for Pods with multiple Containers
voelzmo Jul 26, 2023
895ad14
Merge pull request #5981 from voelzmo/enh/eviction-control-remove-equ…
k8s-ci-robot Jul 27, 2023
5b129d1
Merge pull request #5970 from kawych/tpu
k8s-ci-robot Jul 27, 2023
66b56c5
Merge pull request #5989 from voelzmo/enh/eviction-control-aep-for-mu…
k8s-ci-robot Jul 27, 2023
ecfdc21
Fix broken hyperlink
droctothorpe Jul 26, 2023
66aa3bd
Update vertical-pod-autoscaler/FAQ.md
voelzmo Jul 28, 2023
fc575c6
Update vertical-pod-autoscaler/FAQ.md
voelzmo Jul 28, 2023
5d7d337
Reword AND/OR combinations for more clarity
voelzmo Jul 28, 2023
e777d79
Fix nil pointer exception for case when node is nil while processing …
jayantjain93 Aug 1, 2023
695aacf
feat: add prometheus basic auth
TessaIO Aug 1, 2023
95990f1
Add error code for invalid reservations to GCE client
hbostan Aug 1, 2023
702e968
Merge pull request #6006 from hbostan/master
k8s-ci-robot Aug 2, 2023
3efb678
Bump golang from 1.20.6 to 1.20.7 in /vertical-pod-autoscaler/builder
dependabot[bot] Aug 2, 2023
80053f6
Support ZeroOrMaxNodeScaling node groups when cleaning up unregistere…
kawych Jul 27, 2023
65342dd
Merge pull request #6009 from kubernetes/dependabot/docker/vertical-p…
k8s-ci-robot Aug 3, 2023
3b44c10
Merge pull request #6002 from kawych/down
k8s-ci-robot Aug 3, 2023
8e621b2
Don't pass nil nodes to GetGpuInfoForMetrics
kawych Aug 4, 2023
d1ad9fa
Merge pull request #6013 from kawych/fixing
k8s-ci-robot Aug 4, 2023
dd4263c
Merge pull request #6003 from jayantjain93/gpu-nil-pointer
k8s-ci-robot Aug 4, 2023
71dca88
Merge pull request #5964 from a7i/balancer-rbac-update-status
k8s-ci-robot Aug 4, 2023
c9b8eee
Merge pull request #5961 from hetznercloud/hcloud-go-v2
k8s-ci-robot Aug 4, 2023
b8d3009
Merge pull request #5979 from voelzmo/enh/doc-vpa-for-custom-resources
k8s-ci-robot Aug 4, 2023
bee7c0f
Merge pull request #5987 from droctothorpe/typos
k8s-ci-robot Aug 4, 2023
76b20e4
Revert "Fix nil pointer exception for case when node is nil while pro…
jayantjain93 Aug 4, 2023
9adef5a
Merge pull request #6014 from jayantjain93/revert-6003-gpu-nil-pointer
k8s-ci-robot Aug 4, 2023
e39d1b0
Clean up NodeGroupConfigProcessor interface
BigDarkClown Aug 3, 2023
c4e1681
docs: add kep to add fswatcher to nanny for automatic nanny configura…
TessaIO Aug 4, 2023
555fa4d
Allow using an external secret instead of using the one the Helm char…
mtougeron Aug 4, 2023
14655d2
Remove the MaxNodeProvisioningTimeProvider interface
BigDarkClown Aug 3, 2023
a3bcd98
Merge pull request #5176 from voelzmo/enh/add-eviction-requirements
k8s-ci-robot Aug 7, 2023
8ea13fe
Fixed the hyperlink for Node group auto discovery.
Shubham82 Aug 8, 2023
407f4bc
Update ResourcePolicy description and limit control README
sachintiptur Aug 8, 2023
3c38918
s390x image support
Saripalli-lavanya Aug 7, 2023
fc5870f
Merge pull request #6011 from BigDarkClown/cleanup
k8s-ci-robot Aug 9, 2023
513f962
Bump golang from 1.20.7 to 1.21.0 in /vertical-pod-autoscaler/builder
dependabot[bot] Aug 9, 2023
893a51b
Merge pull request #6030 from kubernetes/dependabot/docker/vertical-p…
k8s-ci-robot Aug 10, 2023
21223f3
Merge pull request #6026 from sachintiptur/resourcepolicy_comment_update
k8s-ci-robot Aug 10, 2023
6b20ca0
Merge pull request #6022 from Shubham82/fix-hyperlink-node_group_auto…
k8s-ci-robot Aug 10, 2023
1aaf4d0
Merge pull request #6020 from Saripalli-lavanya/sl-s390x
k8s-ci-robot Aug 10, 2023
d5757e1
test
aleksandra-malinowska Aug 10, 2023
76a1cef
Set batch size to target size for atomically scaled groups
aleksandra-malinowska Aug 10, 2023
57df63d
a little extra validation
aleksandra-malinowska Aug 10, 2023
aeaab27
test with 2 atomic groups
aleksandra-malinowska Aug 10, 2023
e1cc8ff
don't block draining other groups when one group has some empty nodes
aleksandra-malinowska Aug 10, 2023
f3ca6ef
Merge pull request #6034 from aleksandra-malinowska/fix-atomic
k8s-ci-robot Aug 11, 2023
e1b03fa
Merge pull request #6005 from AhmedGrati/feat-vpa-add-prometheus-basi…
k8s-ci-robot Aug 11, 2023
0ed75e4
fix: Broken links to testgrid dashboard
khareyash05 Aug 15, 2023
8313492
fix: scale down broken for providers not implementing NodeGroup.GetOp…
apricote Aug 15, 2023
7b12a78
feat(hetzner): use less requests while waiting for server create
apricote Aug 15, 2023
44820bd
Update in-place updates AEP adding details to consider
pbetkier Aug 16, 2023
f956800
Fix Doc with External gRPC
j13tw Aug 17, 2023
bb7c8a1
Merge pull request #6038 from hetznercloud/fix-get-options-calls
k8s-ci-robot Aug 18, 2023
3c9aecb
Add fetch reservations in specific project
jessicaochen Aug 18, 2023
5389947
Merge pull request #6051 from jessicaochen/master
k8s-ci-robot Aug 21, 2023
1f9e70e
Merge pull request #6044 from pbetkier/pbetkier-in-place-aep-consider
k8s-ci-robot Aug 22, 2023
58eed48
Merge pull request #6047 from j13tw/fix-doc
k8s-ci-robot Aug 22, 2023
5e20c44
Merge pull request #6016 from mtougeron/flexible-secret-name
k8s-ci-robot Aug 22, 2023
199570e
Merge pull request #6036 from khareyash05/docs
k8s-ci-robot Aug 23, 2023
533719c
Merge pull request #6039 from hetznercloud/hetzner-exponential-backoff
k8s-ci-robot Aug 23, 2023
6a207c8
kep: add config file format and structure notes
TessaIO Aug 23, 2023
0874fe6
Merge pull request #6015 from AhmedGrati/addon-resizer-kep-proposal-5700
k8s-ci-robot Aug 24, 2023
57d07df
Merge pull request #5927 from MaxRink/rbac
k8s-ci-robot Aug 24, 2023
5c666d3
CA - Git ignore s390x arch binaries
gjtempleton Aug 24, 2023
1b3bbdd
Add support to filter out pods being deleted.
jayantjain93 Aug 23, 2023
a370dc3
Merge pull request #6059 from gjtempleton/ca-update-gitignore-s390x-arch
k8s-ci-robot Aug 25, 2023
fe2e4c0
Merge pull request #6056 from jayantjain93/deletion-timestamp-pod-sca…
k8s-ci-robot Aug 25, 2023
6b81c88
protect admission against empty keys
dbenque Jun 28, 2023
dd8c42b
Update vertical-pod-autoscaler/pkg/admission-controller/resource/pod/…
dbenque Aug 28, 2023
7220ffa
Code review
dbenque Aug 28, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -311,8 +311,7 @@ func TestUpdateResourceRequests(t *testing.T) {
return
}

_, foundEmpty := resources[0].Requests[""]
assert.Equal(t, foundEmpty, false, "empty resourceKey have not been purged")
assert.Contains(t, resources, "", "expected empty resource to be removed")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this is closed but isn't this check kind of opposite of the old one?


cpuRequest := resources[0].Requests[apiv1.ResourceCPU]
assert.Equal(t, tc.expectedCPU.Value(), cpuRequest.Value(), "cpu request doesn't match")
Expand Down