Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor tweaks after preparing VPA 0.14.0 release. #5878

Merged
merged 1 commit into from
Jun 26, 2023

Conversation

kgolab
Copy link
Collaborator

@kgolab kgolab commented Jun 21, 2023

What type of PR is this?

/kind cleanup
/kind documentation

What this PR does / why we need it:

Some minor updates to the instructions on how to release VPA, based on the process done under #5851:

  • use registry.k8s.io rather than k8s.gcr.io,
  • make the copy&paste easier (no need to remove $ manually)
  • add a note about add-version.sh script

@k8s-ci-robot k8s-ci-robot added the kind/documentation Categorizes issue or PR as related to documentation. label Jun 21, 2023
@k8s-ci-robot
Copy link
Contributor

@kgolab: The label(s) kind/clean-up cannot be applied, because the repository doesn't have them.

In response to this:

What type of PR is this?

/kind clean-up
/kind documentation

What this PR does / why we need it:

Some minor updates to the instructions on how to release VPA:

  • use registry.k8s.io rather than k8s.gcr.io,
  • make the copy&paste easier (no need to remove $ manually)
  • add a note about add-version.sh script

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 21, 2023
@kgolab kgolab marked this pull request as draft June 21, 2023 13:50
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 21, 2023
@k8s-ci-robot k8s-ci-robot requested a review from jbartosik June 21, 2023 13:50
@k8s-ci-robot k8s-ci-robot requested a review from krzysied June 21, 2023 13:50
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 21, 2023
Copy link
Collaborator

@jbartosik jbartosik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, one small comment, not giving LGTM to avoid merge before you see the comment

([example](https://github.com/kubernetes/k8s.io/pull/1318)).

NOTE: You can use the [add-version.sh
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

optional: I'd maybe use stronger wording, I expect the script to be less error prone than humans.
Maybe s/can/should/

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated, PTAL.

@kgolab kgolab marked this pull request as ready for review June 22, 2023 15:05
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 22, 2023
@k8s-ci-robot k8s-ci-robot requested a review from jbartosik June 22, 2023 15:05
Copy link
Contributor

@mwielgus mwielgus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 26, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jbartosik, kgolab, mwielgus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit c51dc16 into kubernetes:master Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/vertical-pod-autoscaler cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants