-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding app.kubernetes.io/version label to cluster-autoscaler.labels #5874
Adding app.kubernetes.io/version label to cluster-autoscaler.labels #5874
Conversation
|
Welcome @psimms-r7! |
Hi @psimms-r7 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mwielgus, psimms-r7 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@psimms-r7 Please sign the CLA so that this PR will merge. |
/easycla |
Hi @psimms-r7 please signs the CLA |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@psimms-r7 are you working on this PR? |
Going to close for now given lack of response and signed CLA. #6012 is also addressing this and in a more mergeable state. |
@gjtempleton: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What type of PR is this?
What this PR does / why we need it:
Adding app.kubernetes.io/version label to cluster-autoscaler.labels
In order to track versions
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: