-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add cluster-autoscaler name and version to the user agent #5873
add cluster-autoscaler name and version to the user agent #5873
Conversation
This makes it easier to distinguish between various users of the Go SDK.
/retest |
I'm assuming this failure was a flake and unrelated, is there a way to /retest in this repo? |
Currently the tests can only be retriggered by a new commit or a manual retrigger, I'm not sure whether there's any way we can hook prow commands into the GHA workflows, I'll make a note to have a look. Have manually retriggered for now. |
No worries, thanks for the retest! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: drmorr0, mmerkes, tzneal The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
/kind cleanup
What this PR does / why we need it:
This updates the user agent and makes it easier to distinguish between various users of the Go SDK.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
User-Agent for CAS requests prior to this change:
aws-sdk-go/1.44.24 (go1.20.1; linux; amd64)
After this change:
aws-sdk-go/1.44.24 (go1.20.1; linux; amd64) cluster-autoscaler/v1.28.0-alpha.2
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: