Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add cluster-autoscaler name and version to the user agent #5873

Merged

Conversation

tzneal
Copy link
Contributor

@tzneal tzneal commented Jun 20, 2023

/kind cleanup

What this PR does / why we need it:

This updates the user agent and makes it easier to distinguish between various users of the Go SDK.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

User-Agent for CAS requests prior to this change:
aws-sdk-go/1.44.24 (go1.20.1; linux; amd64)

After this change:
aws-sdk-go/1.44.24 (go1.20.1; linux; amd64) cluster-autoscaler/v1.28.0-alpha.2

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


This makes it easier to distinguish between various users
of the Go SDK.
@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 20, 2023
@k8s-ci-robot k8s-ci-robot added area/provider/aws Issues or PRs related to aws provider area/cluster-autoscaler size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 20, 2023
@tzneal
Copy link
Contributor Author

tzneal commented Jun 20, 2023

/retest

@tzneal
Copy link
Contributor Author

tzneal commented Jun 20, 2023

I'm assuming this failure was a flake and unrelated, is there a way to /retest in this repo?

@gjtempleton
Copy link
Member

Currently the tests can only be retriggered by a new commit or a manual retrigger, I'm not sure whether there's any way we can hook prow commands into the GHA workflows, I'll make a note to have a look. Have manually retriggered for now.

@tzneal
Copy link
Contributor Author

tzneal commented Jun 20, 2023

Currently the tests can only be retriggered by a new commit or a manual retrigger, I'm not sure whether there's any way we can hook prow commands into the GHA workflows, I'll make a note to have a look. Have manually retriggered for now.

No worries, thanks for the retest!

Copy link

@mmerkes mmerkes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@drmorr0
Copy link
Contributor

drmorr0 commented Jun 20, 2023

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: drmorr0, mmerkes, tzneal

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 20, 2023
@drmorr0
Copy link
Contributor

drmorr0 commented Jun 20, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 20, 2023
@k8s-ci-robot k8s-ci-robot merged commit b91b127 into kubernetes:master Jun 20, 2023
@tzneal tzneal deleted the make-user-agent-more-informative branch June 20, 2023 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cluster-autoscaler area/provider/aws Issues or PRs related to aws provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants