Explicitly create and remove buildx builders for VPA components #5867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
kind/bug
Closed
kgolab
reviewed
Jun 16, 2023
I'd rather merge this PR - we'll be able to verify the release process in a new (mine) environment then. If we hit trouble again, let's revert - but I can see a lot of value in independent verification by full release process in a previously-unused env. |
voelzmo
force-pushed
the
fix/create-and-remove-buildx-builders
branch
from
569daf1 to
e84f770
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kgolab, voelzmo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
Explicitly create a
builderto be used withdocker buildxand configure it for use during the build. Previously, the build would take whichever builder was currently configured on the machine, which could lead to inconsistencies with the builder'soutputbehavior. See the discussion in the v0.14.0 release issue for more context.The builder created here is of type
docker-containerand needs and explicitoutputconfigured – the flag--loadis a shorthand for--output=type=docker.Special notes for your reviewer:
Additional make target were created, such that we can re-use the builder across the different platforms. Creating and tearing down a builder takes time, which we want to avoid doing too often.
Does this PR introduce a user-facing change?