[cherry-pick to 1.26]: add annotation to ignore local storage volume during scale down #5789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- this is so that scale down is not blocked on local storage volume - for pods where it is okay to ignore local storage volume Signed-off-by: vadasambar <[email protected]> fix: tests failing - there was a problem in the logic Signed-off-by: vadasambar <[email protected]> test: add unit test for `IgnoreLocalStorageVolumeKey` Signed-off-by: vadasambar <[email protected]> refactor: use `IgnoreLocalStorageVolumeKey` in tests instead of hardcoding the annotation Signed-off-by: vadasambar <[email protected]> fix: wording for test name - `pod with EmptyDir but IgnoreLocalStorageVolumeKey annotation` -> `pod with EmptyDir and IgnoreLocalStorageVolumeKey annotation` Signed-off-by: vadasambar <[email protected]> fix: simulator drain tests failing - set local storage vol name (required) Signed-off-by: vadasambar <[email protected]> refactor: add support for multiple vals in `safe-to-evict-local-volume` annotation - add more unit tests Signed-off-by: vadasambar <[email protected]> refactor: rename ignore local vol key `safe-to-evict-local-volume` -> `safe-to-evict-local-volumes` - abtract code to process annotation into a separate fn - shorten name for test cases Signed-off-by: vadasambar <[email protected]> docs: update FAQ with info about `safe-to-evict-local-volumes` annotation Signed-off-by: vadasambar <[email protected]> docs: add the FAQ for `safe-to-evict-local-volumes` annotation Signed-off-by: vadasambar <[email protected]> docs: fix formatting for `safe-to-evict-local-volumes` in FAQ Signed-off-by: vadasambar <[email protected]> docs: format the `safe-to-evict-local-volumes` as a bullet Signed-off-by: vadasambar <[email protected]> docs: fix `Unless` -> `unless` to make it consistent with other lines Signed-off-by: vadasambar <[email protected]> test: add an extra test for mismatching local vol value in annotation Signed-off-by: vadasambar <[email protected]> docs: make the wording clearer - for `safe-to-evict-local-volumes` annotation Signed-off-by: vadasambar <[email protected]> (cherry picked from commit b663f13)
k8s-ci-robot
added
kind/feature
k8s-ci-robot
added
the
size/L
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mwielgus, vadasambar The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check #5594
What type of PR is this?
This is a cherry-pick of #5594
/kind feature
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: