Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cherry-pick to 1.26]: implement function to identify if node is present in aws #5787

Merged
merged 1 commit into from
May 22, 2023
Merged

[cherry-pick to 1.26]: implement function to identify if node is present in aws #5787

merged 1 commit into from
May 22, 2023

Conversation

vadasambar
Copy link
Member

Check #5774

What type of PR is this?

This is a cherry-pick of #5632

/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@vadasambar
fix: implement function to identify if node is present in aws
c008ff0 
- this is a follow-up to kubernetes#5054
- this might fix kubernetes#4456

Signed-off-by: vadasambar <[email protected]>

fix: make `HasInstance` in aws provider thread-safe

Signed-off-by: vadasambar <[email protected]>
(cherry picked from commit 1cb55fe)
@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 22, 2023
@k8s-ci-robot k8s-ci-robot requested a review from drmorr0 May 22, 2023 04:44
@k8s-ci-robot k8s-ci-robot requested a review from jaypipes May 22, 2023 04:44
@vadasambar vadasambar mentioned this pull request May 22, 2023
Closed
mwielgus
mwielgus approved these changes May 22, 2023
View reviewed changes
Copy link
Contributor

@mwielgus mwielgus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 22, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mwielgus, vadasambar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 22, 2023
@k8s-ci-robot k8s-ci-robot merged commit ec85e8e into kubernetes:cluster-autoscaler-release-1.26 May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mwielgus mwielgus mwielgus approved these changes

@drmorr0 drmorr0 Awaiting requested review from drmorr0

@jaypipes jaypipes Awaiting requested review from jaypipes

Assignees

@mwielgus mwielgus

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cluster-autoscaler cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vadasambar @k8s-ci-robot @mwielgus