Fix/asg resource tags for 1.23.x #5739
Conversation
k8s-ci-robot
added
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: paleozogt The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
paleozogt
force-pushed
the
fix/asg-resource-tags-1.23
branch
from
0ca0666 to
91ea3d2
Compare
| @@ -325,6 +325,7 @@ func buildAutoscaler() (core.Autoscaler, error) { | |||
| nodeInfoComparatorBuilder = nodegroupset.CreateAzureNodeInfoComparator | |||
| } else if autoscalingOptions.CloudProviderName == cloudprovider.AwsProviderName { | |||
| nodeInfoComparatorBuilder = nodegroupset.CreateAwsNodeInfoComparator | |||
| opts.Processors.TemplateNodeInfoProvider = nodeinfosprovider.NewAsgTagResourceNodeInfoProvider() | |||
There was a problem hiding this comment.
nodeinfosprovider will need to be added to the imports.
Signed-off-by: tombokombo <[email protected]>
Signed-off-by: tombokombo <[email protected]>
Signed-off-by: tombokombo <[email protected]>
paleozogt
force-pushed
the
fix/asg-resource-tags-1.23
branch
from
91ea3d2 to
7a83082
Compare
|
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
k8s-ci-robot
added
the
lifecycle/stale
|
The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle rotten |
k8s-ci-robot
added
lifecycle/rotten
|
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /close |
|
@k8s-triage-robot: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What type of PR is this?
/kind bug
What this PR does / why we need it:
Applies #5214 to 1.23 for clusters that can't upgrade their k8s version yet.
Which issue(s) this PR fixes:
Fixes #5164
Special notes for your reviewer:
Does this PR introduce a user-facing change?
NONE
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: