Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update VPA dependency github.com/emicklei/go-restful/v3 #5482

Merged
merged 1 commit into from
Feb 22, 2023
Merged

Update VPA dependency github.com/emicklei/go-restful/v3 #5482

merged 1 commit into from
Feb 22, 2023

Conversation

jbartosik
Copy link
Collaborator

/kind cleanup

To pull in a fix for vulnerability in the dependency

#5455

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 7, 2023
@k8s-ci-robot k8s-ci-robot added area/vertical-pod-autoscaler approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 7, 2023
@jbartosik
Copy link
Collaborator Author

Test error looks like an unrelated problem in CA (test run):

 # k8s.io/autoscaler/cluster-autoscaler/processors/nodeinfosprovider
Error: processors/nodeinfosprovider/asg_tag_resource_node_info_provider.go:38:67: not enough arguments in call to NewMixedTemplateNodeInfoProvider
	have (*time.Duration)
	want (*time.Duration, bool)
FAIL	k8s.io/autoscaler/cluster-autoscaler [build failed]

@jbartosik
Copy link
Collaborator Author

/retest

@jbartosik
Copy link
Collaborator Author

@mwielgus PTAL

1 similar comment
@jbartosik
Copy link
Collaborator Author

@mwielgus PTAL

mwielgus
mwielgus approved these changes Feb 22, 2023
View reviewed changes
Copy link
Contributor

@mwielgus mwielgus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 22, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jbartosik, mwielgus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit fb9e55b into kubernetes:master Feb 22, 2023
@jbartosik jbartosik deleted the update-dep branch February 22, 2023 09:30
@jbartosik jbartosik mentioned this pull request Feb 22, 2023
Merged
k8s-ci-robot added a commit that referenced this pull request Feb 22, 2023
@k8s-ci-robot
Merge pull request #5525 from jbartosik/patch-0-13
678b6de 
Cherry pick #5482 and #5484 to VPA release 0.13 branch
@voelzmo voelzmo mentioned this pull request Mar 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mwielgus mwielgus mwielgus approved these changes

@kgolab kgolab Awaiting requested review from kgolab

@krzysied krzysied Awaiting requested review from krzysied

Assignees

@mwielgus mwielgus

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/vertical-pod-autoscaler cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jbartosik @k8s-ci-robot @mwielgus