E2e test admission pod recommendation mismatch #5232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Containers in recommendation can be different from recommendations in pod: - A new container can be added to a pod. At first there will be no recommendation for the container - A container can be removed from pod. For some time recommendation will contain recommendation for the old container - Container can be renamed. Then there will be recommendation for container under its old name. Add tests for what VPA does in those situations.
Containers in recommendation can be different from recommendations in pod: - A new container can be added to a pod. At first there will be no recommendation for the container - A container can be removed from pod. For some time recommendation will contain recommendation for the old container - Container can be renamed. Then there will be recommendation for container under its old name. Add tests for what VPA does in those situations, when limit range exists.
k8s-ci-robot
added
kind/bug
k8s-ci-robot
added
the
approved
|
I ran tests in my cluster (whole admission-controller suite, including those I add in this PR) and they passed. |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jbartosik, mwielgus The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
navinjoy
pushed a commit
to navinjoy/autoscaler
that referenced
this pull request
Oct 26, 2022
…pod-recommendation-mismatch E2e test admission pod recommendation mismatch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which component this PR applies to?
VPA admission contoroller
What type of PR is this?
/kind bug
What this PR does / why we need it:
Add E2E tests for behavior described in #3966. Fix should make test cases with limit range behave the way tests without limit range do now.
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: