-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Option to ignore pod extended resources #5166
Conversation
Welcome @tombokombo! |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: tombokombo The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This PR may require API review. If so, when the changes are ready, complete the pre-review checklist and request an API review. Status of requested reviews is tracked in the API Review project. |
@tombokombo: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign Extended resources aren't necessarily infinite. Ignoring them can therefore have an opposite effect: CA not scaling up, thinking the pod would fit (but it can't due to lack of extended resources). I think we need a way of injecting extended resources into in-memory template nodes CA is using for simulations. This is already something we have for GPU. |
Got it, thanks! Will take a look at the other one then. /close |
@x13n: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Which component this PR applies to?
autoscaler
What type of PR is this?
/kind feature
/kind api-change
What this PR does / why we need it:
If you try to use extended/custom resources as described in k8s https://kubernetes.io/docs/tasks/configure-pod-container/extended-resource/, CA will not trigger scale up for pods with custom/extended resource because predicates will fail with Insufficient resource.
This option introduce possibility to ignore extended/custom resource and let CA make calculation based on real resources like cpu, memory etc.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: