Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to ignore pod extended resources #5166

Closed

Conversation

tombokombo
Copy link
Contributor

Which component this PR applies to?

autoscaler

What type of PR is this?

/kind feature

/kind api-change

What this PR does / why we need it:

If you try to use extended/custom resources as described in k8s https://kubernetes.io/docs/tasks/configure-pod-container/extended-resource/, CA will not trigger scale up for pods with custom/extended resource because predicates will fail with Insufficient resource.
This option introduce possibility to ignore extended/custom resource and let CA make calculation based on real resources like cpu, memory etc.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

A new option has been added to cluster-autoscaler. `ignore-pod-resources` allows autoscaler to ignore extended/custom resources defined on pod and let CA do scheduling calculations as there is no extended/custom resource defined.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 5, 2022
@k8s-ci-robot
Copy link
Contributor

Welcome @tombokombo!

It looks like this is your first PR to kubernetes/autoscaler 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/autoscaler has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 5, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: tombokombo
Once this PR has been reviewed and has the lgtm label, please assign feiskyer for approval by writing /assign @feiskyer in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-triage-robot
Copy link

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 23, 2022
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 27, 2022
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 18, 2022
@k8s-ci-robot
Copy link
Contributor

@tombokombo: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@x13n
Copy link
Member

x13n commented Jan 9, 2023

/assign

Extended resources aren't necessarily infinite. Ignoring them can therefore have an opposite effect: CA not scaling up, thinking the pod would fit (but it can't due to lack of extended resources). I think we need a way of injecting extended resources into in-memory template nodes CA is using for simulations. This is already something we have for GPU.

@tombokombo
Copy link
Contributor Author

@x13n this was kind of workaround, please take a look at proper solution #5214
This PR could be closed in favor of #5214
thx

@x13n
Copy link
Member

x13n commented Jan 27, 2023

Got it, thanks! Will take a look at the other one then.

/close

@k8s-ci-robot
Copy link
Contributor

@x13n: Closed this PR.

In response to this:

Got it, thanks! Will take a look at the other one then.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cluster-autoscaler cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/feature Categorizes issue or PR as related to a new feature. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants