Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update VPA and VPA E2E dependencies: K8s, Go, Ginkgo #5149

Merged
merged 3 commits into from
Aug 30, 2022

Conversation

jbartosik
Copy link
Collaborator

Which component this PR applies to?

VPA

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Update dependencies of VPA and VPA e2e tests.

I ran into problems with VPA dependencies since with 1.25 there are some changes. I want to get them in before releasing VPA 0.12.0

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Aug 30, 2022
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 30, 2022
@jbartosik
Copy link
Collaborator Author

/hold
This compiles but I when I run tests I see panics

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 30, 2022
@jbartosik jbartosik force-pushed the vpa-on-k-25-ginkgo-2 branch from c1822dc to 3f7ef8e Compare August 30, 2022 16:13
@jbartosik
Copy link
Collaborator Author

/hold cancel

I've run full-vpa tests with those changes (both VPA and tests) and they passed

@mwielgus @krzysied please take a look

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 30, 2022
Copy link
Contributor

@mwielgus mwielgus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 30, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jbartosik, mwielgus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 035e762 into kubernetes:master Aug 30, 2022
@jbartosik jbartosik deleted the vpa-on-k-25-ginkgo-2 branch September 6, 2022 12:19
navinjoy pushed a commit to navinjoy/autoscaler that referenced this pull request Oct 26, 2022
Update VPA and VPA E2E dependencies: K8s, Go, Ginkgo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/vertical-pod-autoscaler cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants