Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #4588: Support attribute-based instance selection for AWS #5145

Closed
wants to merge 13 commits into from
Closed

Automated cherry pick of #4588: Support attribute-based instance selection for AWS #5145

wants to merge 13 commits into from

Conversation

AustinSiu
Copy link
Contributor

Cherry pick of #4588 on cluster-autoscaler-release-1.24.

#4588: Support attribute-based instance selection for AWS

For details on the cherry pick process, see the cherry pick requests page.

AustinSiu and others added 13 commits August 29, 2022 23:10
@AustinSiu
Support attribute-based instance selection for AWS
10c7e45
@AustinSiu
Add support for LT Instance Requirements with no overrides in MIP
31af9f5
@AustinSiu
Update and fix tests
45bb569
@AustinSiu
Update README with IAM for new APIs
56d7890
@AustinSiu
Check MIP instance req overrides before LT overrides
161e5b6
@AustinSiu
Add nil check when building tempalte with requirements, improve reada…
5081fb3 
…bility
@AustinSiu
Improve nil checking, some naming, replace json logic for requirement…
95d60ee 
… translation with field-setting
@AustinSiu
Add instance type nil check
2d73cc8
@AustinSiu
Consolidate DescribeLaunchTemplateVersions logic into one function
43e5796
@AustinSiu
Add testing for describing launch template data
29ad206
@AustinSiu
Fix guard on instance type overrides when requirements present
c95a9af
@AustinSiu
Restore previous sdk version
daa2e8e
@AustinSiu
Update all imports across cloudprovider
8a4f4a8
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Aug 30, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: AustinSiu
Once this PR has been reviewed and has the lgtm label, please assign jeffwan for approval by writing /assign @jeffwan in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested a review from feiskyer August 30, 2022 04:11
@mwielgus
Copy link
Contributor

The build is failing. Please fix.

@mwielgus mwielgus requested review from gjtempleton and removed request for aleksandra-malinowska and feiskyer August 30, 2022 08:54
@mwielgus
Copy link
Contributor

Build not fixed for 30 days, closing. Feel free to reopen once fixed.

@mwielgus mwielgus closed this Sep 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gjtempleton gjtempleton Awaiting requested review from gjtempleton

Assignees
No one assigned
Labels
area/cluster-autoscaler cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AustinSiu @k8s-ci-robot @mwielgus @jbartosik