Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add x13n to cluster autoscaler reviewers #5135

Merged
merged 1 commit into from
Aug 30, 2022

Conversation

x13n
Copy link
Member

@x13n x13n commented Aug 26, 2022

Per https://github.com/kubernetes/community/blob/master/community-membership.md#reviewer:

  • member for at least 3 months - yup, many years now
  • Primary reviewer for at least 5 PRs to the codebase - yup, 28 so far (link)
  • Reviewed or merged at least 20 substantial PRs to the codebase - yup, in addition to the above authored 20 so far (link)
  • Knowledgeable about the codebase - yes, but no idea how to prove it here
  • Sponsored by a subproject approver
  • May either self-nominate, be nominated by an approver in this subproject, or be nominated by a robot

/assign @MaciekPytel

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 26, 2022
@MaciekPytel
Copy link
Contributor

+1 from me, I'm happy to take the role of " subproject approver sponsor". @x13n has been one of the most active contributors / reviewers for over a year now.

I'll wait with lgtm/approve for a few days to give other approvers time to raise objections and if there are none I'm going to merge this.

@towca
Copy link
Collaborator

towca commented Aug 26, 2022

No objections from me, well deserved!

@feiskyer
Copy link
Member

+1
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 29, 2022
Copy link
Contributor

@mwielgus mwielgus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mwielgus, x13n

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 30, 2022
@k8s-ci-robot k8s-ci-robot merged commit aa2e25f into kubernetes:master Aug 30, 2022
navinjoy pushed a commit to navinjoy/autoscaler that referenced this pull request Oct 26, 2022
Add x13n to cluster autoscaler reviewers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants