-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump k/k dependencies to v1.25.0 together with go.mod go version. #5132
Conversation
/lgtm |
/approve |
Do we also want to lint everything in the same commit? |
Did you check with @jbartosik that he is ok with bumping stuff in VPA? |
/hold |
Do you want me to split into two commits? |
Not necessarily, just wanted to make sure that you want to cover both deps, go, linitng and vpa in the PR. |
My main purpose was to bump dependencies and as it turned out other things were required to make it work and pass the tests and verifications. |
/assign @jbartosik |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
VPA part LGTM
Yes, done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jbartosik, MaciekPytel, mwielgus, olagacek, towca The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Bump k/k dependencies to v1.25.0 together with go.mod go version.
Which component this PR applies to?
Bump k/k dependencies to v1.25.0 together with bumping go.mod go version to 1.19.
What type of PR is this?
/kind feature
What this PR does / why we need it:
Bumps k/k dependencies to v1.25.0 together with bumping go.mod go version to 1.19.