Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump k/k dependencies to v1.25.0 together with go.mod go version. #5132

Merged
merged 1 commit into from
Aug 26, 2022

Conversation

olagacek
Copy link
Contributor

Which component this PR applies to?

Bump k/k dependencies to v1.25.0 together with bumping go.mod go version to 1.19.

What type of PR is this?

/kind feature

What this PR does / why we need it:

Bumps k/k dependencies to v1.25.0 together with bumping go.mod go version to 1.19.

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Aug 26, 2022
@towca
Copy link
Collaborator

towca commented Aug 26, 2022

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 26, 2022
@MaciekPytel
Copy link
Contributor

/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 26, 2022
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 26, 2022
@mwielgus
Copy link
Contributor

Do we also want to lint everything in the same commit?

@mwielgus
Copy link
Contributor

Did you check with @jbartosik that he is ok with bumping stuff in VPA?

@mwielgus
Copy link
Contributor

/hold
(to get my questions answered)

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 26, 2022
@olagacek
Copy link
Contributor Author

Do we also want to lint everything in the same commit?

Do you want me to split into two commits?

@mwielgus
Copy link
Contributor

Not necessarily, just wanted to make sure that you want to cover both deps, go, linitng and vpa in the PR.

@olagacek
Copy link
Contributor Author

Not necessarily, just wanted to make sure that you want to cover both deps, go, linitng and vpa in the PR.

My main purpose was to bump dependencies and as it turned out other things were required to make it work and pass the tests and verifications.

@olagacek
Copy link
Contributor Author

/assign @jbartosik

Copy link
Collaborator

@jbartosik jbartosik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

VPA part LGTM

@olagacek
Copy link
Contributor Author

Did you check with @jbartosik that he is ok with bumping stuff in VPA?

Yes, done.

@mwielgus mwielgus removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 26, 2022
Copy link
Contributor

@mwielgus mwielgus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 26, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jbartosik, MaciekPytel, mwielgus, olagacek, towca

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit f3242d8 into kubernetes:master Aug 26, 2022
navinjoy pushed a commit to navinjoy/autoscaler that referenced this pull request Oct 26, 2022
Bump k/k dependencies to v1.25.0 together with go.mod go version.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants