add metric for skipped scaling events #5059
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change adds a new metric, skipped_scale_events_count, which will record the number of times that the CA has chosen to skip a scaling event. The metric contains a label for the scaling direction (up or down) and the reason. This patch includes usages for the new metric based on CPU or Memory limits being reached in eiter a scale up or down.
k8s-ci-robot
added
kind/feature
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: elmiko, mwielgus The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
elmiko
added a commit
to elmiko/cluster-autoscaler-operator
that referenced
this pull request
Sep 14, 2022
this change updates the resource limit alerts to use the new metric introduced in kubernetes/autoscaler#5059.
elmiko
added a commit
to elmiko/cluster-autoscaler-operator
that referenced
this pull request
Sep 14, 2022
this change updates the resource limit alerts to use the new metric introduced in kubernetes/autoscaler#5059.
navinjoy
pushed a commit
to navinjoy/autoscaler
that referenced
this pull request
Oct 26, 2022
add metric for skipped scaling events
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which component this PR applies to?
cluster-autoscaler
What type of PR is this?
/kind feature
What this PR does / why we need it:
This change adds a new metric, skipped_scale_events_count, which will
record the number of times that the CA has chosen to skip a scaling
event. The metric contains a label for the scaling direction (up or down)
and the reason.
This patch includes usages for the new metric based on CPU or Memory
limits being reached in eiter a scale up or down.
User Story
As a cluster autoscaler user, I would like to create alerts to inform me when my cluster is exceeding its resource limits. Having a Prometheus metric to measure this would allow me to create automated alerting.
Which issue(s) this PR fixes:
n/a
Special notes for your reviewer:
none
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: