Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metrics for Hetzner API calls #5049

Merged
merged 1 commit into from
Aug 9, 2022

Conversation

maksim-paskal
Copy link
Contributor

Provide metrics for Hetzner API calls; helps identifying slowness, throttling causes, and errors bursts.

Signed-off-by: Maksim Paskal paskal.maksim@gmail.com

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jul 26, 2022

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: maksim-paskal / name: Maksim Paskal (a43d9ca)

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 26, 2022
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jul 26, 2022
@maksim-paskal maksim-paskal force-pushed the hetzner-metrics branch 2 times, most recently from dcc9195 to be0f3ff Compare July 26, 2022 07:03
@maksim-paskal
Copy link
Contributor Author

@LKaemmerling please take a look!

@LKaemmerling
Copy link
Contributor

Hey @maksim-paskal,

this looks fine from my side :)

@LKaemmerling
Copy link
Contributor

/assign @feiskyer

Verified

This commit was signed with the committer’s verified signature.
kanadgupta Kanad Gupta
Provide metrics for Hetzner API calls; helps identifying slowness, throttling causes, and errors bursts.

Signed-off-by: Maksim Paskal <paskal.maksim@gmail.com>
@maksim-paskal
Copy link
Contributor Author

rebased

Copy link
Contributor

@mwielgus mwielgus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: LKaemmerling, maksim-paskal, mwielgus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 9, 2022
@k8s-ci-robot k8s-ci-robot merged commit 6a12973 into kubernetes:master Aug 9, 2022
@maksim-paskal maksim-paskal deleted the hetzner-metrics branch August 9, 2022 12:56
navinjoy pushed a commit to navinjoy/autoscaler that referenced this pull request Oct 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cluster-autoscaler cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants