Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump VPA builder Go version #5039

Merged
merged 1 commit into from
Jul 22, 2022
Merged

Conversation

voelzmo
Copy link
Contributor

@voelzmo voelzmo commented Jul 22, 2022

Which component this PR applies to?

vertical-pod-autoscaler

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Bump the Go version to the most recent 1.17 release, such that we can cut a new release

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 22, 2022
@jbartosik
Copy link
Collaborator

Sounds good to me. Could you clarify this part, please:

such that we can cut a new release

How does using 1.17.2 instead of 1.17.0 affect a release? (I don't plan to cut new VPA release until K8s 1.25)

@voelzmo
Copy link
Contributor Author

voelzmo commented Jul 22, 2022

I don't plan to cut new VPA release until K8s 1.25

I wasn't sure what your release plans were, and should have asked about this, sorry.
We have some internal discussions going on, now that people discovered that the Go version on the VPA was pretty outdated (0.10.0 still used Go 1.14) for a long time, and now they're watching closely when/if we're returning to a non-EOL version.
If I understand correctly, you're going to cut a new VPA release somewhat soon after August 23rd?

@jbartosik
Copy link
Collaborator

I don't plan to cut new VPA release until K8s 1.25

I wasn't sure what your release plans were, and should have asked about this, sorry. We have some internal discussions going on, now that people discovered that the Go version on the VPA was pretty outdated (0.10.0 still used Go 1.14) for a long time, and now they're watching closely when/if we're returning to a non-EOL version. If I understand correctly, you're going to cut a new VPA release somewhat soon after August 23rd?

Yes, I want to cut a new release soon after 1.25 (so if there are no delays to the release soon after 2022-08-23). Last time I was doing a release there was some delay (e2e started failing around the so I needed to fix them). I hope this time things go smoothly.


This PR is to make sure we're using up to date Go version in the next VPA version?

@voelzmo
Copy link
Contributor Author

voelzmo commented Jul 22, 2022

Ok, thanks for the explanations regarding the plans for the next release.

This PR is to make sure we're using up to date Go version in the next VPA version?

Yes, that was the intention.

Copy link
Collaborator

@jbartosik jbartosik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 22, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jbartosik, voelzmo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 22, 2022
@k8s-ci-robot k8s-ci-robot merged commit fc0666c into kubernetes:master Jul 22, 2022
navinjoy pushed a commit to navinjoy/autoscaler that referenced this pull request Oct 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants