-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump VPA builder Go version #5039
Conversation
Sounds good to me. Could you clarify this part, please:
How does using 1.17.2 instead of 1.17.0 affect a release? (I don't plan to cut new VPA release until K8s 1.25) |
I wasn't sure what your release plans were, and should have asked about this, sorry. |
Yes, I want to cut a new release soon after 1.25 (so if there are no delays to the release soon after 2022-08-23). Last time I was doing a release there was some delay (e2e started failing around the so I needed to fix them). I hope this time things go smoothly. This PR is to make sure we're using up to date Go version in the next VPA version? |
Ok, thanks for the explanations regarding the plans for the next release.
Yes, that was the intention. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jbartosik, voelzmo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Bump VPA builder Go version
Which component this PR applies to?
vertical-pod-autoscaler
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Bump the Go version to the most recent 1.17 release, such that we can cut a new release
Special notes for your reviewer:
Does this PR introduce a user-facing change?