CA: GCE: Return UnknownArch from ToSystemArchitecture for invalid architectures #4982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hitectures PR kubernetes#4973 changed ToSystemArchitecture behavior to return DefaultArch instead of UnknownArch for invalid architectures. This kind of defaulting makes sense while parsing KUBE_ENV, but prevents using the function in contexts where an invalid architecture should result in an error. This commit reverts ToSystemArchitecture to previous behavior, and moves defaulting to the callsite.
k8s-ci-robot
added
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: towca The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/lgtm |
k8s-ci-robot
added
the
lgtm
navinjoy
pushed a commit
to navinjoy/autoscaler
that referenced
this pull request
Oct 26, 2022
CA: GCE: Return UnknownArch from ToSystemArchitecture for invalid architectures
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #4973 changed ToSystemArchitecture behavior to return DefaultArch
instead of UnknownArch for invalid architectures. This kind of defaulting
makes sense while parsing KUBE_ENV, but prevents using the function
in contexts where an invalid architecture should result in an error.
This commit reverts ToSystemArchitecture to previous behavior, and
moves defaulting to the callsite.