Sort the list of container resource recommendations in VPA status #4979
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When iterating through a map of RecommendedPodResources, the order of the container names is not guaranteed, see: https://go.dev/blog/maps This will cause the order of the slice of ContainerRecommendations in the VPA status to change on every call to GET the object. The fix is to deliberately sort a list of the container names, and use the list to key over the map.
k8s-ci-robot
added
kind/bug
k8s-ci-robot
added
size/L
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mwielgus, sibucan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
navinjoy
pushed a commit
to navinjoy/autoscaler
that referenced
this pull request
Oct 26, 2022
…ommendations Sort the list of container resource recommendations in VPA status
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which component this PR applies to?
vertical-pod-autoscaler
What type of PR is this?
/kind bug
What this PR does / why we need it:
When iterating through a map of RecommendedPodResources, the order of the container names is not guaranteed, see: https://go.dev/blog/maps
This will cause the order of the slice of ContainerRecommendations in the VPA status to change on every call to GET the object.
The fix is to deliberately sort a list of the container names, and use the list to key over the map.
Which issue(s) this PR fixes:
Fixes #4910
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: