Vendor aws sdk in cloudprovider

[AustinSiu]

Which component this PR applies to?

Cluster Autoscaler

What type of PR is this?

/kind feature
/kind api-change

What this PR does / why we need it:

To get around issues with updating the version of Cluster Autoscaler's direct dependency on aws-sdk-go, this PR adds a copy of the aws-sdk-go at a specific newer version within the AWS cloudprovider.

Which issue(s) this PR fixes:

Unblocks several PRs: #4424 (comment) and #4588

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

[AustinSiu]

/assign @gjtempleton who has full surrounding context

[k8s-triage-robot]

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

[jaypipes]

/approve

@gjtempleton this is a huge PR because it replaces the vendored aws-sdk-go package, but other than that doesn't do anything functional. Can we send this along?

[gjtempleton]

@AustinSiu Sorry for the delay, now getting round to this.

You'll need to exclude the newly vendored package from the verification scripts to pass the failing test. You can follow the approach taken by this commit.

[gjtempleton]

A couple of notes/queries/requests before this looks good to merge:

• Do we need some instructions for those who might want/need to update the vendored code in the future given it's not as simple as just copying the SDK code in?
• Could you squash the commits down a bit before merge? I'm thinking something around the 4 commits mark, though if you have. an alternative suggestion, more than happy to listen:
  • Initial vendoring
  • Changes made to the vendored code to make it work
  • Changes to the core go.mod etc.
  • Changes to the verify scripts

[AustinSiu]

A couple of notes/queries/requests before this looks good to merge:

• Do we need some instructions for those who might want/need to update the vendored code in the future given it's not as simple as just copying the SDK code in?

• Could you squash the commits down a bit before merge? I'm thinking something around the 4 commits mark, though if you have. an alternative suggestion, more than happy to listen:

  • Initial vendoring
  • Changes made to the vendored code to make it work
  • Changes to the core go.mod etc.
  • Changes to the verify scripts

@gjtempleton Makes sense, I've cleaned up the commits and added some instructions around the vendored SDK. Please let me know if there are any other instructions I should add, etc. Thanks!

[gjtempleton]

Nope, that looks good to go, thanks for your persistence with this!

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AustinSiu, gjtempleton, jaypipes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• cluster-autoscaler/cloudprovider/aws/OWNERS [gjtempleton,jaypipes]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment