Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CA Chart - Cleanup Chart Maintainers #4941

Merged

Conversation

gjtempleton
Copy link
Member

Which component this PR applies to?

CA Helm Chart.

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Removes old maintainers from the Chart.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

cc: @yurrriq @sc250024 @mgoodness please let me know if any of you actually still want to be involved in maintaining this, however figured best to remove the risk of any of you being pestered to support something you're no longer actively involved with.

Does this PR introduce a user-facing change?


Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 2, 2022
@gjtempleton gjtempleton added area/helm-charts and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 2, 2022
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 2, 2022
@gjtempleton
Copy link
Member Author

/hold Sticking a hold on for a few days to allow for any maintainer being removed to object.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 3, 2022
@yurrriq
Copy link

yurrriq commented Jun 8, 2022

Thanks for checking. It looks like my last commit was on 5 November, 2019 in the old repo and the history wasn't preserved here. Please feel free to remove me. 😃

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gjtempleton, yurrriq

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sc250024
Copy link
Contributor

Go ahead 🫡

@gjtempleton gjtempleton force-pushed the CA-Chart-Cleanup-Maintainers branch from a3e2a22 to 8e83371 Compare June 16, 2022 13:54
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 16, 2022
@gjtempleton
Copy link
Member Author

Thanks both, and thanks for all your past work on it!

Have bumped the version again.

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 16, 2022
@x13n
Copy link
Member

x13n commented Jun 24, 2022

Looks like this doesn't need to hang.
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 24, 2022
@k8s-ci-robot k8s-ci-robot merged commit 6ce299e into kubernetes:master Jun 24, 2022
navinjoy pushed a commit to navinjoy/autoscaler that referenced this pull request Oct 26, 2022
…Maintainers

CA Chart - Cleanup Chart Maintainers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cluster-autoscaler area/helm-charts cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants