Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CA - AWS - Instance List Update 2022-05-25 #4917

Merged
merged 1 commit into from
May 29, 2022

Conversation

yselkowitz
Copy link
Contributor

Which component this PR applies to?

cluster-autoscaler

What type of PR is this?

/kind feature

What this PR does / why we need it:

Update the AWS instance type list, adding c7g, i4i, x2i(e)dn classes, plus c6a.metal and m6a.metal types.

Which issue(s) this PR fixes:

Special notes for your reviewer:

I had to run the generator specifying a region (us-east-1) as a workaround for #4859.

Does this PR introduce a user-facing change?

Updated AWS instance types, including c7g, i4i, and x2i(e)dn.

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 25, 2022
@k8s-ci-robot
Copy link
Contributor

Welcome @yselkowitz!

It looks like this is your first PR to kubernetes/autoscaler 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/autoscaler has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 25, 2022
@gjtempleton
Copy link
Member

Hey, thanks for the PR!

/area provider/aws
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the area/provider/aws Issues or PRs related to aws provider label May 29, 2022
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 29, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gjtempleton, yselkowitz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 29, 2022
@k8s-ci-robot k8s-ci-robot merged commit adc8114 into kubernetes:master May 29, 2022
yselkowitz added a commit to yselkowitz/machine-api-provider-aws that referenced this pull request May 29, 2022
This includes changes from the following upstream PRs:
kubernetes/autoscaler#4683
kubernetes/autoscaler#4917
@gjtempleton
Copy link
Member

@yselkowitz Just seen AWS decided to launch two new instance families the day after you raised this PR, because of course. Do you want to re-run it and raise another PR?

I'll raise some PRs against the release branches before I cut 1.19 to 1.23 patch releases later this week to include the ones you've added as well as the latest new ones.

yselkowitz added a commit to yselkowitz/machine-api-provider-aws that referenced this pull request May 30, 2022
navinjoy pushed a commit to navinjoy/autoscaler that referenced this pull request Oct 26, 2022
CA - AWS - Instance List Update 2022-05-25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/aws Issues or PRs related to aws provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants