[CA][Helm] Allow skipping service creation #4837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
kind/feature
|
/assign @gjtempleton |
|
Hey, thanks for the PR! Can you please give it a minor rather than patch version bump as its adding a new piece of functionality? |
avorima
force-pushed
the
chart/disable-service
branch
from
d4d31ee to
8354dcc
Compare
|
@gjtempleton done |
k8s-ci-robot
added
the
needs-rebase
avorima
force-pushed
the
chart/disable-service
branch
from
8354dcc to
800efd2
Compare
k8s-ci-robot
removed
the
needs-rebase
|
Thanks! |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: avorima, gjtempleton The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
navinjoy
pushed a commit
to navinjoy/autoscaler
that referenced
this pull request
Oct 26, 2022
…vice [CA][Helm] Allow skipping service creation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which component this PR applies to?
helm charts
What type of PR is this?
/kind feature
What this PR does / why we need it:
The service is the only resource that can't be disabled. As I see it its only purpose is to expose metrics and some optional things like profiling and snapshots. If none of these are used a service shouldn't be required.
Special notes for your reviewer:
Does this PR introduce a user-facing change?