Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correction of Pod creation fails if VPA has only one controlledResources #4768

Closed
wants to merge 4 commits into from
Closed

Conversation

jmalmeid
Copy link

Which component this PR applies to?

vertical-pod-autoscaler

What type of PR is this?

/kind bug

What this PR does / why we need it:

Correction of Pod creation fails if VPA has only one controlledResources

Which issue(s) this PR fixes:

Fixes #3902

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 25, 2022
@jmalmeid
Copy link
Author

/assign @jbartosik

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jmalmeid
To complete the pull request process, please ask for approval from jbartosik after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jbartosik
Copy link
Collaborator

I'm confused. #3902 is already marked as closed, could you explain why this PR is marking it as fixed again? Is the problem reoccurring?

@jmalmeid
Copy link
Author

jmalmeid commented Apr 5, 2022

Ok. This issue is resolved on 0.10.0.
The pull request can be closed/rejected.

@jmalmeid jmalmeid closed this Apr 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/vertical-pod-autoscaler cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[VPA] Pod creation fails if VPA has only one controlledResources
3 participants