Charts - CA - Remove AWS IAM Docs - Replace With Link #4701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
kind/documentation
gjtempleton
force-pushed
the
Charts-CA-IAM-Docs-Repoint
branch
from
3100f57 to
df1c458
Compare
k8s-ci-robot
added
the
approved
|
This PR would solve my issue with #3216 since I was following instructions in the readme.md file to configure my IAM policy. Being redirected to the correct page is an acceptable solution for me. |
k8s-ci-robot
added
the
needs-rebase
gjtempleton
force-pushed
the
Charts-CA-IAM-Docs-Repoint
branch
from
df1c458 to
4de33ca
Compare
k8s-ci-robot
removed
the
needs-rebase
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gjtempleton, mwielgus The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which component this PR applies to?
helm-charts - Cluster Autoscaler
What type of PR is this?
/kind documentation
What this PR does / why we need it:
Addresses the fact we currently specify the AWS IAM permissions required by the CA running in AWS in both the chart's README and the cloudprovider implementation's docs, making it easy for the two to fall out of sync (as seen by the multiple comments on issue #3216. Just updating the README in the chart wouldn't fully address this, as users could use an old version of the chart, but update the CA's image tag to one requiring new IAM permissions. This addresses this by removing the duplication, and instead linking to the README of the AWS cloudprovider implementation as a single source of truth.
Which issue(s) this PR fixes:
None
Special notes for your reviewer:
N/A
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: