Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for Debugging Snapshot #4552

Merged
merged 1 commit into from
Dec 30, 2021

Conversation

jayantjain93
Copy link
Contributor

Which component this PR applies to?

Cluster-Autoscaler

What type of PR is this?

/kind feature

What this PR does / why we need it:

This PR introduces a new Debugging Tool, which would make it easier to analyse larger clusters.

Fixes #4346

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE


Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Dec 22, 2021
@jayantjain93 jayantjain93 force-pushed the debugging-snapshot branch 3 times, most recently from 035e301 to 7801d73 Compare December 22, 2021 10:20
cluster-autoscaler/core/static_autoscaler.go Outdated Show resolved Hide resolved
cluster-autoscaler/debuggingsnapshot/debugging_snapshot.go Outdated Show resolved Hide resolved
cluster-autoscaler/debuggingsnapshot/debugging_snapshot.go Outdated Show resolved Hide resolved
cluster-autoscaler/debuggingsnapshot/debugging_snapshot.go Outdated Show resolved Hide resolved
cluster-autoscaler/core/static_autoscaler.go Show resolved Hide resolved
@jayantjain93 jayantjain93 force-pushed the debugging-snapshot branch 3 times, most recently from e261d4c to a8a6013 Compare December 29, 2021 08:29
@jayantjain93 jayantjain93 force-pushed the debugging-snapshot branch 3 times, most recently from 24d3a71 to 87d850f Compare December 30, 2021 08:27
@x13n
Copy link
Member

x13n commented Dec 30, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 30, 2021
Copy link
Contributor

@mwielgus mwielgus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jayantjain93, mwielgus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cluster-autoscaler cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Proposal: Cluster Autoscaler Debugging Snapshot
5 participants