switch azure clients to non-legacy repo #4494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
marwanad
force-pushed
the
switch-azure-clients
branch
from
3d9f740 to
d128e00
Compare
k8s-ci-robot
added
size/XXL
marwanad
force-pushed
the
switch-azure-clients
branch
2 times, most recently
from
87dfada to
6d379a1
Compare
marwanad
commented
Dec 6, 2021
| @@ -157,12 +157,6 @@ func BuildAzureConfig(configReader io.Reader) (*Config, error) { | |||
| cfg.ClusterName = os.Getenv("AZURE_CLUSTER_NAME") | |||
| cfg.NodeResourceGroup = os.Getenv("AZURE_NODE_RESOURCE_GROUP") | |||
|
|
|||
| subscriptionID, err := getSubscriptionIdFromInstanceMetadata() | |||
There was a problem hiding this comment.
I had to get rid of that because I was getting:
'sigs.k8s.io/cloud-provider-azure/pkg/provider' imports package with invalid import comment
on importing. Looking back at it - I highly doubt this was ever used since most people would either provide AZ config or explicitly sub ID from env vars.
marwanad
force-pushed
the
switch-azure-clients
branch
from
6d379a1 to
e5abd7b
Compare
|
/area provider/azure |
k8s-ci-robot
added
the
area/provider/azure
marwanad
force-pushed
the
switch-azure-clients
branch
2 times, most recently
from
2ca9d79 to
b244d8a
Compare
marwanad
force-pushed
the
switch-azure-clients
branch
from
b244d8a to
afb443f
Compare
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: feiskyer, marwanad The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This switches the azure cloudprovider clients to not use the legacy repo since its no longer maintained.
Dependency is now pulled from sig.k8s.io/https://github.com/kubernetes-sigs/cloud-provider-azure