Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add configuration diagrams to clusterapi readme #4474

Merged
merged 1 commit into from
Nov 23, 2021

Conversation

elmiko
Copy link
Contributor

@elmiko elmiko commented Nov 21, 2021

This change adds ascii diagrams to help illustrate the differences
between the various authentication configurations for the clusterapi
provider. Due to the distributed nature of Cluster API and its ability
to have several Kubernetes clusters managed from a central location, the
kubeconfig authentication options for it are slightly more complex than
other providers.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 21, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elmiko

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 21, 2021
@elmiko
Copy link
Contributor Author

elmiko commented Nov 21, 2021

@jackfrancis this is something we had talked about quite a long time ago, i got inspired ;)

@elmiko elmiko force-pushed the update-capi-readme branch 4 times, most recently from d9a5db7 to f871d65 Compare November 21, 2021 15:58
@enxebre
Copy link
Member

enxebre commented Nov 22, 2021

Nice, thanks!
/area provider/cluster-api

@k8s-ci-robot k8s-ci-robot added the area/provider/cluster-api Issues or PRs related to Cluster API provider label Nov 22, 2021
This change adds ascii diagrams to help illustrate the differences
between the various authentication configurations for the clusterapi
provider. Due to the distributed nature of Cluster API and its ability
to have several Kubernetes clusters managed from a central location, the
kubeconfig authentication options for it are slightly more complex than
other providers.
@elmiko elmiko force-pushed the update-capi-readme branch from f871d65 to 540a794 Compare November 22, 2021 15:13
@elmiko
Copy link
Contributor Author

elmiko commented Nov 22, 2021

update

  • changed common kubeconfig diagram to show a single source for mgmt/workload cluster

@shysank
Copy link
Contributor

shysank commented Nov 23, 2021

/lgtm
Thanks for doing this!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 23, 2021
@k8s-ci-robot k8s-ci-robot merged commit 732cb65 into kubernetes:master Nov 23, 2021
@elmiko elmiko deleted the update-capi-readme branch November 23, 2021 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/cluster-api Issues or PRs related to Cluster API provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants