Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use DescribeInstanceTypes API to get EC2 instance type details #4468

Merged
merged 2 commits into from
Dec 8, 2021
Merged

Use DescribeInstanceTypes API to get EC2 instance type details #4468

merged 2 commits into from
Dec 8, 2021

Conversation

AustinSiu
Copy link
Contributor

This change addresses #4436 by replacing the existing pricing API call used to resolve instance types with EC2's DescribeInstanceTypes API. It also adds unit tests and updates the readme.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Nov 15, 2021 •
edited
Loading

CLA Signed

The committers are authorized under a signed CLA.

@k8s-ci-robot
Copy link
Contributor

Welcome @AustinSiu!

It looks like this is your first PR to kubernetes/autoscaler 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/autoscaler has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 15, 2021
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 15, 2021
@AustinSiu AustinSiu force-pushed the useDescribeInstanceTypesApi branch from edde39e to 955eaef Compare November 16, 2021 00:51
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 16, 2021
@AustinSiu AustinSiu force-pushed the useDescribeInstanceTypesApi branch from 955eaef to 0a3e5a6 Compare November 16, 2021 01:58
@gjtempleton
Copy link
Member

/area provider/aws

@k8s-ci-robot k8s-ci-robot added the area/provider/aws Issues or PRs related to aws provider label Nov 16, 2021
@gjtempleton gjtempleton mentioned this pull request Nov 28, 2021
Closed
@AustinSiu
Copy link
Contributor Author

@aleksandra-malinowska @feiskyer may I ask when you will be able to review this PR? Thanks!

@feiskyer
Copy link
Member

feiskyer commented Dec 3, 2021 •
edited
Loading

jaypipes
jaypipes suggested changes Dec 6, 2021
View reviewed changes
Copy link
Contributor

@jaypipes jaypipes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting a bit of documentation in the gen.go file (see inline comment) but otherwise this approach is excellent and MUCH cleaner than the existing strategy. Well done, @AustinSiu.

cluster-autoscaler/cloudprovider/aws/README.md Show resolved Hide resolved
bwagner5
bwagner5 approved these changes Dec 7, 2021
View reviewed changes
Copy link

@bwagner5 bwagner5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from Jay's comment on docs for the permissions, this LGTM! Nice work!

@AustinSiu AustinSiu force-pushed the useDescribeInstanceTypesApi branch from 0a3e5a6 to 73459ec Compare December 7, 2021 07:18
jaypipes
jaypipes approved these changes Dec 7, 2021
View reviewed changes
Copy link
Contributor

@jaypipes jaypipes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 great work on this @AustinSiu! :)

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AustinSiu, bwagner5, jaypipes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 7, 2021
@AustinSiu AustinSiu force-pushed the useDescribeInstanceTypesApi branch from 73459ec to 94d0edf Compare December 7, 2021 16:53
@jaypipes
Copy link
Contributor

jaypipes commented Dec 8, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 8, 2021
@k8s-ci-robot k8s-ci-robot merged commit d56b5dc into kubernetes:master Dec 8, 2021
@gjtempleton gjtempleton mentioned this pull request Dec 13, 2021
Merged
@ismailbaskin ismailbaskin mentioned this pull request Feb 18, 2022
Merged
@gjtempleton gjtempleton mentioned this pull request Apr 5, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaypipes jaypipes jaypipes approved these changes

@bwagner5 bwagner5 bwagner5 approved these changes

@aleksandra-malinowska aleksandra-malinowska Awaiting requested review from aleksandra-malinowska

@feiskyer feiskyer Awaiting requested review from feiskyer

Assignees

@jaypipes jaypipes

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cluster-autoscaler area/provider/aws Issues or PRs related to aws provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@AustinSiu @k8s-ci-robot @gjtempleton @feiskyer @jaypipes @bwagner5