Missing Policy for the k8s-cluster-autoscaler to read ASG Tags

[RafaelMoreira1180778]

When deploying the template for the example for the auto-discovery of the ASG on AWS (tweaked to my needs) I noticed this error being thrown:

aws_cloud_provider.go:389] Failed to create AWS Manager: cannot autodiscover ASGs: AccessDenied: User: [assumed-role] is not authorized to perform: autoscaling:DescribeTags because no identity-based policy allows the autoscaling:DescribeTags action

After adding the autoscaling:DescribeTags alongside all the others present in the README.file the k8s-cluster-autoscaler started being able to discover new ASG correctly.

[k8s-ci-robot]

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

---

• If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
• If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
• If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
• Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at: [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[k8s-ci-robot]

Welcome @RafaelMoreira1180778!

It looks like this is your first PR to kubernetes/autoscaler 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/autoscaler has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: RafaelMoreira1180778
To complete the pull request process, please assign jaypipes after the PR has been reviewed.
You can assign the PR to them by writing /assign @jaypipes in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• cluster-autoscaler/cloudprovider/aws/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[gjtempleton]

/area provider/aws

Hey, thanks for the PR, can you please follow the instructions to sign the CLA in the first comment?

[gjtempleton]

/assign @gjtempleton

The use of autodiscovery by tags, and the requirement to add the permission for autoscaling:DescribeTags is already covered in the sentence immediately following the snippet you're modifying. If anything I'd rather be more explicit and provide two snippets:

1. The minimum permissions required to run the CA in AWS with a hardcoded list of ASGs
2. The minimum permissions required to run the CA in AWS with a ASG autodiscovery

[k8s-ci-robot]

@RafaelMoreira1180778: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[gjtempleton]

Hi @RafaelMoreira1180778, have you had a chance to address the feedback on the PR?

[mwielgus]

CLA not signed, comments not addressed, closing. Feel free to reopen once fixed.