Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CA - AWS - Instance List Update 29-10-21 - 1.19 release branch #4429

Merged
merged 1 commit into from
Nov 2, 2021
Merged

CA - AWS - Instance List Update 29-10-21 - 1.19 release branch #4429

merged 1 commit into from
Nov 2, 2021

Conversation

sturman
Copy link
Contributor

@sturman sturman commented Oct 29, 2021 •
edited
Loading

Fix #4427

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 29, 2021
@gjtempleton
Copy link
Member

Thanks, before I approve this one, would you mind squashing the commits down to one please?

(I'm also slightly confused as to why my previous PR to this release branch was apparently missing so many instance types, but that's not an issue for this PR.)

@sturman sturman force-pushed the CA-EC2-AWS-Instance-List-Update-29-10-21-1.19 branch from 0f1497b to 05976b9 Compare November 2, 2021 07:04
@sturman
Copy link
Contributor Author

sturman commented Nov 2, 2021

Hi @gjtempleton. I've just squashed commits. Please review. Thanks

@gjtempleton
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 2, 2021
@sturman
Copy link
Contributor Author

sturman commented Nov 2, 2021

/assign @jaypipes

jaypipes
jaypipes approved these changes Nov 2, 2021
View reviewed changes
Copy link
Contributor

@jaypipes jaypipes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jaypipes
Copy link
Contributor

jaypipes commented Nov 2, 2021

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: feiskyer, jaypipes, sturman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 2, 2021
@k8s-ci-robot k8s-ci-robot merged commit 3de345e into kubernetes:cluster-autoscaler-release-1.19 Nov 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feiskyer feiskyer feiskyer approved these changes

@jaypipes jaypipes jaypipes approved these changes

@aleksandra-malinowska aleksandra-malinowska Awaiting requested review from aleksandra-malinowska

Assignees

@jaypipes jaypipes

@gjtempleton gjtempleton

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cluster-autoscaler cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@sturman @gjtempleton @jaypipes @k8s-ci-robot @feiskyer @jbartosik