DOCS - Narrow the scope of resources the suggested IAM policy grants access to

[trumant]

The previous policy suggested that the autoscaler be granted permissions that would allow it to modify any auto scaling group within the account.

The revised guidance explains how to narrow the resources where permissions are granted more appropriately.

[k8s-ci-robot]

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

---

• If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
• If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
• If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
• Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at: [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[k8s-ci-robot]

Welcome @trumant!

It looks like this is your first PR to kubernetes/autoscaler 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/autoscaler has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: trumant
To complete the pull request process, please assign jeffwan after the PR has been reviewed.
You can assign the PR to them by writing /assign @jeffwan in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• cluster-autoscaler/cloudprovider/aws/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[trumant]

CLA completed

[trumant]

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

• If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
• If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
• If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
• Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at: [email protected]

CLA is now signed. Maybe the PR status will get updated.

[trumant]

/check-cla

[gjtempleton]

/assign @gjtempleton
Thanks for the PR, I'm a big supporter of making clearer to users how they can restrict the permissions they're granting in their IAM roles, however I have some concerns about recommending hardcoded lists of ASG names. I know that in a number of environments users create idempotent node groups, meaning any change to an ASG's config results in a new autoscaling group.

In the suggested new recommendation for the IAM role this would require users to then update the CA's IAM role as well.

I wonder if a better approach would be documenting a range of approaches for users (the immediate alternative that comes to mind is restricting by a known conditional on tags on the ASGs)?

[trumant]

@gjtempleton Great feedback and I appreciate the review. I'll see what I can cook up.

[gjtempleton]

Hi @trumant have you had a chance to address this?

I ask as I was planning on revisiting this area of the docs to make a number of changes based on this, and other user feedback and don't want to step on your toes but would like to include recommendations along the same lines as this.

[gjtempleton]

/close
Closing in favour of #4670 as a more comprehensive rework of the AWS IAM docs.

[k8s-ci-robot]

@gjtempleton: Closed this PR.

In response to this:

/close
Closing in favour of #4670 as a more comprehensive rework of the AWS IAM docs.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.