Adjust KEP for customized recommender #4329
Conversation
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
the
approved
Use a list of structs instead of a list of strings to choose recommenders. This will allow us to pass parameters to recommenders (if we decide we want to allow that). Related to kubernetes#3913
jbartosik
force-pushed
the
multi-recommender-kep-1
branch
from
fcdc24e to
5f00de6
Compare
|
@bskiba, @kgolab, @wangchen615 - please take a look. |
| type: array | ||
| items: | ||
| properties: | ||
| name: |
There was a problem hiding this comment.
Could you please comment (preferably in the KEP itself) why a struct?
I know it's forward-looking but maybe there already is a use-case that can support this choice?
[updated] I can see the answer below but it would still be good to reference it earlier.
|
|
||
| ```golang | ||
|
|
||
| // VerticalPodAutoscalerRecommenderSelector points to a specificic Vertical Pod Autoscaler recommender | ||
| // in the future it might pass parameters to the er. |
There was a problem hiding this comment.
Recommender, fixed.
|
|
||
| // Name of the recommender responsible for generating recommendation for this object. | ||
| RecommenderName []string `json:"recommenderName,omitempty" protobuf:"bytes,4,opt,name=recommenderName"` | ||
| // Name of the recommender responsible for generating recommendation for this object. |
There was a problem hiding this comment.
This comment should be updated as well.
vertical-pod-autoscaler/enhancements/3919-customized-recommender-vpa/README.md
Outdated
Show resolved
Hide resolved
jbartosik
force-pushed
the
multi-recommender-kep-1
branch
from
28d8dac to
a90669c
Compare
|
/retest |
jbartosik
force-pushed
the
multi-recommender-kep-1
branch
from
a90669c to
23902ca
Compare
There was a problem hiding this comment.
@jbartosik , Thanks so much for your PR on the KEP. It helps me a lot to update the code.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jbartosik, wangchen615 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/hold |
k8s-ci-robot
added
the
do-not-merge/hold
|
A bit late but LGTM for me as well. |
Use a list of structs instead of a list of strings to choose
recommenders.
This will allow us to pass parameters to recommenders (if we decide we
want to allow that).
Related to #3913