-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CA] [AWS examples] Add priorityClassName & securityContext & upgrade image #4303
[CA] [AWS examples] Add priorityClassName & securityContext & upgrade image #4303
Conversation
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Welcome @damienleger! |
I signed it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, thanks for the PR.
One quick comment for you for now.
I also want to double-check all the examples still work as intended with the new security settings and won't be able to do that until next week.
cluster-autoscaler/cloudprovider/aws/examples/cluster-autoscaler-autodiscover.yaml
Outdated
Show resolved
Hide resolved
/assign @gjtempleton |
Hello @gjtempleton, thanks for reply
The modified (*) I use the 1.22 image in EKS 1.21 since there is no API deprecated in 1.22 used by cluster-autoscaler but I agree with you, it's simpler to stick with the 1:1 version mapping with EKS and cluster-autoscaler. |
Thanks for that. /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: damienleger, gjtempleton The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hello, some improvements on AWS examples.
To ensure the pod is scheduled
To run pod as non-root (security best practice)
And use the last image (1.22.0).