Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport Merge pull request #4274 to upstream/cluster-autoscaler-release-1.20 #4290

Merged
merged 1 commit into from
Sep 7, 2021
Merged

Backport Merge pull request #4274 to upstream/cluster-autoscaler-release-1.20 #4290

merged 1 commit into from
Sep 7, 2021

Conversation

ipochi
Copy link
Contributor

@ipochi ipochi commented Aug 27, 2021

As per this comment

Backporting the fix to upstream/cluster-autoscaler-release-1.20

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Aug 27, 2021
@ipochi ipochi changed the base branch from master to cluster-autoscaler-release-1.20 August 27, 2021 07:31
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Aug 27, 2021
@k8s-ci-robot k8s-ci-robot requested review from gianarb and v-pap August 27, 2021 07:31
@ipochi ipochi mentioned this pull request Aug 27, 2021
Closed
mwielgus
mwielgus approved these changes Sep 7, 2021
View reviewed changes
Copy link
Contributor

@mwielgus mwielgus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 7, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ipochi, mwielgus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 7, 2021
@k8s-ci-robot k8s-ci-robot merged commit 20b1808 into kubernetes:cluster-autoscaler-release-1.20 Sep 7, 2021
@ipochi ipochi deleted the backport-1.20 branch September 7, 2021 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mwielgus mwielgus mwielgus approved these changes

@gianarb gianarb Awaiting requested review from gianarb

@v-pap v-pap Awaiting requested review from v-pap

Assignees

@mwielgus mwielgus

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cluster-autoscaler cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ipochi @k8s-ci-robot @mwielgus @jbartosik